Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1612953004: Image filters: Make a recursive, forward-mapping bounds traversal. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Image filters: Make a recursive, forward-mapping bounds traversal which respects the CropRect. This is useful when you want the device-space bounds of a primitive after filtering. (This may also eventually subsume computeFastBounds()). This CL generalizes filterBounds() and onFilterBounds() to take a mapping direction. It also makes filterBounds() responsible for calling onFilterNodeBounds() and applying the crop rect, simplifying onFilterBounds(). BUG=skia:4627 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612953004 Committed: https://skia.googlesource.com/skia/+/d8ff5b336e586ad971ebcafa5fb2eb1e7ac95589

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update to ToT #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Don't pass clipBounds to CropRect::applyTo #

Patch Set 7 : Style fixes, comments, and SkDisplacementMap::onFilterBounds fix #

Patch Set 8 : Refactor onFilterNodeBounds() calls into filterImage() #

Patch Set 9 : Refactor onFilterNodeBounds() calls into filterImage(); fix 6-param applyCropRect(); fix 0-input on… #

Patch Set 10 : Formatting, etc #

Patch Set 11 : Formatting, comments etc #

Patch Set 12 : Update to ToT #

Patch Set 13 : Fix comments #

Patch Set 14 : Fix comments (again) #

Patch Set 15 : Update to ToT #

Patch Set 16 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -53 lines) Patch
M include/core/SkImageFilter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +32 lines, -20 lines 0 comments Download
M include/effects/SkComposeImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkTileImageFilter.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +31 lines, -17 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkLocalMatrixImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -5 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612953004/1
4 years, 11 months ago (2016-01-21 22:12:39 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 23:32:38 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612953004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612953004/60001
4 years, 11 months ago (2016-01-23 04:04:33 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-23 04:25:19 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612953004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612953004/200001
4 years, 11 months ago (2016-01-24 15:37:21 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-24 15:48:49 UTC) #13
Stephen White
reed@: PTAL. Thanks!
4 years, 11 months ago (2016-01-25 15:11:24 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612953004/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612953004/260001
4 years, 11 months ago (2016-01-25 15:11:49 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 15:28:18 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612953004/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612953004/300001
4 years, 11 months ago (2016-01-26 18:00:40 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 18:11:31 UTC) #24
Stephen White
reed@: ping?
4 years, 11 months ago (2016-01-27 14:53:14 UTC) #25
Stephen White
Brian: PTAL. Thanks!
4 years, 11 months ago (2016-01-27 19:37:06 UTC) #27
bsalomon
+Mike and +Rob who know the SkIF code a lot better than I do.
4 years, 11 months ago (2016-01-27 21:00:57 UTC) #29
reed1
nice. lgtm
4 years, 10 months ago (2016-01-28 15:50:01 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612953004/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612953004/300001
4 years, 10 months ago (2016-01-28 16:11:36 UTC) #32
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 16:23:05 UTC) #34
Message was sent while issue was closed.
Committed patchset #16 (id:300001) as
https://skia.googlesource.com/skia/+/d8ff5b336e586ad971ebcafa5fb2eb1e7ac95589

Powered by Google App Engine
This is Rietveld 408576698