chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 161293002: mac: Allows extensions to hide the bookmark page menu item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 161293002: mac: Allows extensions to hide the bookmark page menu item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to remaining rsesek/wittman comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_cocoa.h ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index fb0a9e16e934e00f403e28a473f1803cd7b2dd58..616dc7ae0a8b75f92687c8cf25014ad3650b9a47 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -51,6 +51,7 @@

#include "components/autofill/core/common/password_form.h"

#include "content/public/browser/native_web_keyboard_event.h"

#include "content/public/browser/notification_details.h"

+#include "content/public/browser/notification_service.h"

Mike Wittman 2014/02/26 20:16:03 Remove this header?

erikchen 2014/02/26 20:53:52 Done.

#include "content/public/browser/notification_source.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_view.h"

@@ -758,10 +759,10 @@ BrowserWindowCocoa::GetRenderViewHeightInsetWithDetachedBookmarkBar() {

void BrowserWindowCocoa::ShowPageActionPopup(

const extensions::Extension* extension) {

- NOTIMPLEMENTED();

+ [cocoa_controller() activatePageAction:extension->id()];

}

void BrowserWindowCocoa::ShowBrowserActionPopup(

const extensions::Extension* extension) {

- NOTIMPLEMENTED();

+ [cocoa_controller() activateBrowserAction:extension->id()];

}