Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 161293002: mac: Allows extensions to hide the bookmark page menu item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to remaining rsesek/wittman comments. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/mac/mac_util.h" 10 #include "base/mac/mac_util.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 #import "chrome/browser/ui/cocoa/web_dialog_window_controller.h" 44 #import "chrome/browser/ui/cocoa/web_dialog_window_controller.h"
45 #import "chrome/browser/ui/cocoa/website_settings_bubble_controller.h" 45 #import "chrome/browser/ui/cocoa/website_settings_bubble_controller.h"
46 #include "chrome/browser/ui/search/search_model.h" 46 #include "chrome/browser/ui/search/search_model.h"
47 #include "chrome/browser/ui/tabs/tab_strip_model.h" 47 #include "chrome/browser/ui/tabs/tab_strip_model.h"
48 #include "chrome/browser/web_applications/web_app.h" 48 #include "chrome/browser/web_applications/web_app.h"
49 #include "chrome/common/chrome_switches.h" 49 #include "chrome/common/chrome_switches.h"
50 #include "chrome/common/pref_names.h" 50 #include "chrome/common/pref_names.h"
51 #include "components/autofill/core/common/password_form.h" 51 #include "components/autofill/core/common/password_form.h"
52 #include "content/public/browser/native_web_keyboard_event.h" 52 #include "content/public/browser/native_web_keyboard_event.h"
53 #include "content/public/browser/notification_details.h" 53 #include "content/public/browser/notification_details.h"
54 #include "content/public/browser/notification_service.h"
Mike Wittman 2014/02/26 20:16:03 Remove this header?
erikchen 2014/02/26 20:53:52 Done.
54 #include "content/public/browser/notification_source.h" 55 #include "content/public/browser/notification_source.h"
55 #include "content/public/browser/web_contents.h" 56 #include "content/public/browser/web_contents.h"
56 #include "content/public/browser/web_contents_view.h" 57 #include "content/public/browser/web_contents_view.h"
57 #include "grit/chromium_strings.h" 58 #include "grit/chromium_strings.h"
58 #include "grit/generated_resources.h" 59 #include "grit/generated_resources.h"
59 #include "ui/base/l10n/l10n_util_mac.h" 60 #include "ui/base/l10n/l10n_util_mac.h"
60 #include "ui/gfx/rect.h" 61 #include "ui/gfx/rect.h"
61 62
62 #if defined(ENABLE_ONE_CLICK_SIGNIN) 63 #if defined(ENABLE_ONE_CLICK_SIGNIN)
63 #import "chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h" 64 #import "chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h"
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 // gets enlarged by H. 752 // gets enlarged by H.
752 // I believe these "automatic" resizing are caused by setAutoresizingMask of 753 // I believe these "automatic" resizing are caused by setAutoresizingMask of
753 // of the cocoa view in WebContentsViewMac, which defeats the purpose of 754 // of the cocoa view in WebContentsViewMac, which defeats the purpose of
754 // WebContentsDelegate::GetSizeForNewRenderView i.e. to prevent resizing of 755 // WebContentsDelegate::GetSizeForNewRenderView i.e. to prevent resizing of
755 // RenderWidgetHostView in (2) and (3). 756 // RenderWidgetHostView in (2) and (3).
756 return 0; 757 return 0;
757 } 758 }
758 759
759 void BrowserWindowCocoa::ShowPageActionPopup( 760 void BrowserWindowCocoa::ShowPageActionPopup(
760 const extensions::Extension* extension) { 761 const extensions::Extension* extension) {
761 NOTIMPLEMENTED(); 762 [cocoa_controller() activatePageAction:extension->id()];
762 } 763 }
763 764
764 void BrowserWindowCocoa::ShowBrowserActionPopup( 765 void BrowserWindowCocoa::ShowBrowserActionPopup(
765 const extensions::Extension* extension) { 766 const extensions::Extension* extension) {
766 NOTIMPLEMENTED(); 767 [cocoa_controller() activateBrowserAction:extension->id()];
767 } 768 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698