Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1612803002: Test distillability on all pages (Closed)

Created:
4 years, 11 months ago by wychen
Modified:
4 years, 10 months ago
Reviewers:
mdjones, esprehn, dglazkov, jwd
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@mobile-distillable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test distillability on all pages Mobile-friendly pages were early terminated. Now we want to collect UMA for all pages. BUG=577833 Committed: https://crrev.com/5f86476a1b978fddce1a101a26eaad0dc123e280 Cr-Commit-Position: refs/heads/master@{#374530}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase and type safety #

Patch Set 4 : update description #

Total comments: 1

Patch Set 5 : address jwd's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -15 lines) Patch
M components/dom_distiller/content/renderer/distillability_agent.cc View 1 2 5 chunks +20 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 3 chunks +35 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612803002/1
4 years, 11 months ago (2016-01-21 02:49:29 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/92402)
4 years, 11 months ago (2016-01-21 03:29:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612803002/20001
4 years, 11 months ago (2016-01-21 04:20:51 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/92432)
4 years, 11 months ago (2016-01-21 05:19:42 UTC) #8
wychen
PTAL
4 years, 11 months ago (2016-01-21 20:10:55 UTC) #10
mdjones
lgtm
4 years, 11 months ago (2016-01-21 22:12:44 UTC) #11
wychen
+esprehn@
4 years, 11 months ago (2016-01-25 21:52:41 UTC) #13
dglazkov
lgtm
4 years, 10 months ago (2016-02-05 22:02:38 UTC) #14
wychen
+jwd for histograms.xml
4 years, 10 months ago (2016-02-06 01:09:40 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612803002/60001
4 years, 10 months ago (2016-02-06 01:14:47 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19334)
4 years, 10 months ago (2016-02-06 02:38:21 UTC) #20
jwd
histograms LGTM with nit. https://codereview.chromium.org/1612803002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1612803002/diff/60001/tools/metrics/histograms/histograms.xml#newcode8501 tools/metrics/histograms/histograms.xml:8501: + details. nit: can you ...
4 years, 10 months ago (2016-02-09 19:18:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612803002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612803002/80001
4 years, 10 months ago (2016-02-09 22:01:06 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-09 23:37:43 UTC) #25
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 23:38:39 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5f86476a1b978fddce1a101a26eaad0dc123e280
Cr-Commit-Position: refs/heads/master@{#374530}

Powered by Google App Engine
This is Rietveld 408576698