third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp - Issue 1612803002: Test distillability on all pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

Issue 1612803002: Test distillability on all pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mobile-distillable

Patch Set: address jwd's comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

diff --git a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

index 010f9bc2e96467106361df204c21a1f65fa01a46..29aca56fa94bdfc3f17f0dc798e0d9200b1932da 100644

--- a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

+++ b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

@@ -228,11 +228,7 @@ WebDistillabilityFeatures DocumentStatisticsCollector::collectStatistics(Documen

if (!body || !head)

return features;

- if (isMobileFriendly(document)) {

- features.isMobileFriendly = true;

- // We only trigger Reader Mode on non-mobile-friendly pages for now.

- return features;

- }

+ features.isMobileFriendly = isMobileFriendly(document);

double startTime = monotonicallyIncreasingTime();