Don't send the body of the redirected request to the ServiceWorker.

Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent to the ServiceWorker.

This causes an error when "fetch(event.request)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html

Committed: https://crrev.com/8f8aeea280e577fc8dddd2aeb6747f47f3ec502e
Cr-Commit-Position: refs/heads/master@{#371196}

[horo, 2016-01-22 08:10:14]

Description was changed from

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

BUG=573937
==========

to

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This will cause an error when "fetch(request.event)" is called in the
ServiceWorker.
To fix this problem, this patch add has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

[horo, 2016-01-22 08:10:42]

Description was changed from

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This will cause an error when "fetch(request.event)" is called in the
ServiceWorker.
To fix this problem, this patch add has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

to

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
To fix this problem, this patch add has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

[horo, 2016-01-22 08:11:01]

Description was changed from

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
To fix this problem, this patch add has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

to

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

[horo, 2016-01-22 10:25:29]

Description was changed from

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

to

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must be unset when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

[horo, 2016-01-22 10:25:43]

Description was changed from

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must be unset when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

to

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must not be when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

[horo, 2016-01-22 11:25:45]

Description was changed from

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must not be when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
==========

to

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

[horo, 2016-01-25 04:31:21]

Description was changed from

==========
Check request_->has_upload() in ServiceWorkerURLRequestJob::CreateFetchRequest()

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

to

==========
Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

[horo, 2016-01-25 04:32:16]

Description was changed from

==========
Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(request.event)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

to

==========
Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(event.request)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

[horo, 2016-01-25 04:35:37]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2016-01-25 04:35:37]

falken@
Could you please review this?

[falken, 2016-01-25 04:51:57]

lgtm

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html
(right):

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:22:
var hiddenInput = document.createElement('input');
nit: snake_case here and throughout

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:38:
var frameLoadPromise = new Promise(function(resolve) {
I think function(resolve)'s body needs an additional two space indent.

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:39:
frame.addEventListener('load', function() {
same with this function()

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:53:
console.log(decodeURIComponent(text));
debug output?

[horo, 2016-01-25 05:14:51]

Thank you!

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html
(right):

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:22:
var hiddenInput = document.createElement('input');
On 2016/01/25 04:51:57, falken wrote:
> nit: snake_case here and throughout

Done.

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:38:
var frameLoadPromise = new Promise(function(resolve) {
On 2016/01/25 04:51:57, falken wrote:
> I think function(resolve)'s body needs an additional two space indent.

Done.

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:39:
frame.addEventListener('load', function() {
On 2016/01/25 04:51:57, falken wrote:
> same with this function()

Done.

https://codereview.chromium.org/1612423002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html:53:
console.log(decodeURIComponent(text));
On 2016/01/25 04:51:57, falken wrote:
> debug output?

Removed

[horo, 2016-01-25 05:15:18]

The CQ bit was checked by horo@chromium.org

[horo, 2016-01-25 05:15:18]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1612423002/#ps40001
(title: "incorporated falken's comment")

[commit-bot: I haz the power, 2016-01-25 05:15:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612423002/40001

[commit-bot: I haz the power, 2016-01-25 07:35:48]

Description was changed from

==========
Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(event.request)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

to

==========
Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(event.request)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

[commit-bot: I haz the power, 2016-01-25 07:35:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-25 07:36:42]

Description was changed from

==========
Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(event.request)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html
==========

to

==========
Don't send the body of the redirected request to the ServiceWorker.

The upload data in URLRequest is cleared while handing redirects in
URLRequest::Redirect().
But ServiceWorkerURLRequestJob doesn't check it while re-sending the FetchEvent
to the ServiceWorker.

This causes an error when "fetch(event.request)" is called in the ServiceWorker.
It is because request.body must not be set when request.method is GET.
To fix this problem, this patch adds has_upload() check in
ServiceWorkerURLRequestJob::CreateFetchRequest().

BUG=573937
TEST=http/tests/serviceworker/navigation-redirect-body.html

Committed: https://crrev.com/8f8aeea280e577fc8dddd2aeb6747f47f3ec502e
Cr-Commit-Position: refs/heads/master@{#371196}
==========

[commit-bot: I haz the power, 2016-01-25 07:36:45]

Patchset 3 (id:??) landed as
https://crrev.com/8f8aeea280e577fc8dddd2aeb6747f47f3ec502e
Cr-Commit-Position: refs/heads/master@{#371196}