third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html - Issue 1612423002: Don't send the body of the redirected request to the ServiceWorker.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html

Issue 1612423002: Don't send the body of the redirected request to the ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add LayoutTest Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-body.php » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Service Worker: Navigation redirection must clear body</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="../resources/get-host-info.js?pipe=sub"></script>

	6 <script src="resources/test-helpers.js"></script>

	7 <body>

	8 <script>

	9 promise_test(function(t) {

	10 var scope = 'resources/navigation-redirect-body.php';

	11 var script = 'resources/navigation-redirect-body-worker.js';

	12 var registration;

	13 var frame = document.createElement('frame');

	14 frame.src = 'about:blank';

	15 frame.name = 'target_frame';

	16 frame.id = 'frame';

	17 document.body.appendChild(frame);

	18 var form = document.createElement('form');

	19 form.method = 'POST';

	20 form.action = scope;

	21 form.target = 'target_frame';

	22 var hiddenInput = document.createElement('input');
	falken 2016/01/25 04:51:57 nit: snake_case here and throughout nit: snake_case here and throughout horo 2016/01/25 05:14:51 Done. Show quoted text On 2016/01/25 04:51:57, falken wrote: > nit: snake_case here and throughout Done.
	23 hiddenInput.type = 'hidden';

	24 hiddenInput.name = 'data';

	25 hiddenInput.value = 'test data';

	26 var submitButton = document.createElement('input');

	27 submitButton.type = 'submit';

	28 submitButton.value = 'submit';

	29 form.appendChild(hiddenInput);

	30 form.appendChild(submitButton);

	31 document.body.appendChild(form);

	32 return service_worker_unregister_and_register(t, script, scope)

	33 .then(function(r) {

	34 registration = r;

	35 return wait_for_state(t, registration.installing, 'activated');

	36 })

	37 .then(function() {

	38 var frameLoadPromise = new Promise(function(resolve) {
	falken 2016/01/25 04:51:57 I think function(resolve)'s body needs an addition I think function(resolve)'s body needs an additional two space indent. horo 2016/01/25 05:14:51 Done. Show quoted text On 2016/01/25 04:51:57, falken wrote: > I think function(resolve)'s body needs an additional two space indent. Done.
	39 frame.addEventListener('load', function() {
	falken 2016/01/25 04:51:57 same with this function() same with this function() horo 2016/01/25 05:14:51 Done. Show quoted text On 2016/01/25 04:51:57, falken wrote: > same with this function() Done.
	40 resolve(frame.contentWindow.document.body.innerText);

	41 }, false);

	42 });

	43 submitButton.click();

	44 return frameLoadPromise;

	45 })

	46 .then(function(text) {

	47 document.body.removeChild(form);

	48 document.body.removeChild(frame);

	49 var request_uri = decodeURIComponent(text);

	50 assert_equals(

	51 request_uri,

	52 '/serviceworker/resources/navigation-redirect-body.php?redirect');

	53 console.log(decodeURIComponent(text));
	falken 2016/01/25 04:51:57 debug output? debug output? horo 2016/01/25 05:14:51 Removed Show quoted text On 2016/01/25 04:51:57, falken wrote: > debug output? Removed
	54 return registration.unregister();

	55 });

	56 }, 'Navigation redirection must clear body');

	57 </script>

	58 </body>

OLD	NEW