Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 16124009: Revert 204709 "Move instant support to SearchTabHelper." (Closed)

Created:
7 years, 6 months ago by kmadhusu
Modified:
7 years, 6 months ago
Reviewers:
samarth, kmadhusu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 204709 "Move instant support to SearchTabHelper." > Move instant support to SearchTabHelper. > > BUG=none > TEST=none > > Review URL: https://chromiumcodereview.appspot.com/14911005 TBR=kmadhusu@chromium.org,samarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -453 lines) Patch
M trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_page.h View 7 chunks +18 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_page.cc View 9 chunks +43 lines, -55 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_page_unittest.cc View 4 chunks +9 lines, -70 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_tab.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_test_utils.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/search_model.h View 2 chunks +7 lines, -27 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/search_model.cc View 2 chunks +0 lines, -35 lines 0 comments Download
D trunk/src/chrome/browser/ui/search/search_model_unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
MM trunk/src/chrome/browser/ui/search/search_tab_helper.h View 4 chunks +0 lines, -27 lines 0 comments Download
MM trunk/src/chrome/browser/ui/search/search_tab_helper.cc View 5 chunks +1 line, -50 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kmadhusu
7 years, 6 months ago (2013-06-07 21:53:06 UTC) #1
kmadhusu
7 years, 6 months ago (2013-06-07 21:55:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r204945.

Powered by Google App Engine
This is Rietveld 408576698