trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc - Issue 16124009: Revert 204709 "Move instant support to SearchTabHelper."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc

Issue 16124009: Revert 204709 "Move instant support to SearchTabHelper." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc

===================================================================

--- trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc (revision 204944)

+++ trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc (working copy)

@@ -366,15 +366,13 @@

ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));

FocusOmniboxAndWaitForInstantOverlayAndNTPSupport();

- // Open a new tab and navigate to instant URL. Start typing before InstantTab

- // is properly hooked up. Should use the overlay.

+ // Open a new tab and start typing before InstantTab is properly hooked up.

+ // Should use the overlay.

ui_test_utils::NavigateToURLWithDisposition(

browser(),

- instant_url(),

- NEW_BACKGROUND_TAB,

- ui_test_utils::BROWSER_TEST_NONE);

- EXPECT_EQ(2, browser()->tab_strip_model()->count());

- browser()->tab_strip_model()->ActivateTabAt(1, false);

+ GURL(chrome::kChromeUINewTabURL),

+ NEW_FOREGROUND_TAB,

+ ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);

ASSERT_TRUE(SetOmniboxTextAndWaitForOverlayToShow("query"));

// But Instant tab should still exist.

« no previous file with comments | « no previous file | trunk/src/chrome/browser/ui/search/instant_page.h » ('j') | no next file with comments »