Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: rietveld.py

Issue 1612323004: Make apply_issue fail if the content of a large file is missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index 8e99e4bc2a1663b8fb8d094b5d9155154a6aecca..9adc9c5ca1346a99c79552dc62ae77c17c576871 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -148,7 +148,7 @@ class Rietveld(object):
out.append(patch.FilePatchDelete(filename, state['is_binary']))
else:
content = self.get_file_content(issue, patchset, state['id'])
- if not content:
+ if not content or content == 'None':
tandrii(chromium) 2016/01/22 21:08:25 ugh, but whatever works.
Sébastien Marchand 2016/01/22 21:11:20 Yeah, this is ugly and it took me quite some time
# As a precaution due to a bug in upload.py for git checkout, refuse
# empty files. If it's empty, it's not a binary file.
raise patch.UnsupportedPatchFormat(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698