Make apply_issue fail if the content of a large file is missing.

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
@@ skipping 130 matching lines @@
           state.get('property_changes', ''), filename)
 
       if state.get('is_binary'):
         if status[0] == 'D':
           if status[0] != status.strip():
             raise patch.UnsupportedPatchFormat(
                 filename, 'Deleted file shouldn\'t have property change.')
           out.append(patch.FilePatchDelete(filename, state['is_binary']))
         else:
           content = self.get_file_content(issue, patchset, state['id'])
-          if not content:
+          if not content or content == 'None':

[tandrii(chromium), 2016/01/22 21:08:25]

ugh, but whatever works.

[Sébastien Marchand, 2016/01/22 21:11:20]

Yeah, this is ugly and it took me quite some time to debug this (because I was
printing the value of |content|, so I was confused by the fact that no exception
was raised although content was 'None'...). I don't know who's emitting this
string, but we should probably change it to something less confusing (or set it
to the 'real' None).

             # As a precaution due to a bug in upload.py for git checkout, refuse
             # empty files. If it's empty, it's not a binary file.
             raise patch.UnsupportedPatchFormat(
                 filename,
                 'Binary file is empty. Maybe the file wasn\'t uploaded in the '
                 'first place?')
           out.append(patch.FilePatchBinary(
               filename,
               content,
               svn_props,
@@ skipping 575 matching lines @@
       self, issue, patchset, reason, clobber, revision, builders_and_tests,
       master=None, category='cq'):
     logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
         (builders_and_tests, issue))
 
   def trigger_distributed_try_jobs(  # pylint:disable=R0201
       self, issue, patchset, reason, clobber, revision, masters,
       category='cq'):
     logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
         (masters, issue))