Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: src/key-accumulator.h

Issue 1612323003: Introduce {FAST,SLOW}_STRING_WRAPPER_ELEMENTS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/key-accumulator.h
diff --git a/src/key-accumulator.h b/src/key-accumulator.h
index 8a4d886f515db441e1a8346daf4f0442e1a1dc03..2c90bba1651b87ef9da64a91aaf06395f802e71c 100644
--- a/src/key-accumulator.h
+++ b/src/key-accumulator.h
@@ -36,12 +36,10 @@ class KeyAccumulator final BASE_EMBEDDED {
~KeyAccumulator();
bool AddKey(uint32_t key);
- bool AddKey(Object* key, AddKeyConversion convert = DO_NOT_CONVERT);
Jakob Kummerow 2016/01/26 14:21:24 Forcing callers to think about what behavior they
Toon Verwaest 2016/01/27 15:02:21 Acknowledged.
- bool AddKey(Handle<Object> key, AddKeyConversion convert = DO_NOT_CONVERT);
- void AddKeys(Handle<FixedArray> array,
- AddKeyConversion convert = DO_NOT_CONVERT);
- void AddKeys(Handle<JSObject> array,
- AddKeyConversion convert = DO_NOT_CONVERT);
+ bool AddKey(Object* key, AddKeyConversion convert);
+ bool AddKey(Handle<Object> key, AddKeyConversion convert);
+ void AddKeys(Handle<FixedArray> array, AddKeyConversion convert);
+ void AddKeys(Handle<JSObject> array, AddKeyConversion convert);
void AddKeysFromProxy(Handle<JSObject> array);
Maybe<bool> AddKeysFromProxy(Handle<JSProxy> proxy, Handle<FixedArray> keys);
void AddElementKeysFromInterceptor(Handle<JSObject> array);

Powered by Google App Engine
This is Rietveld 408576698