Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: src/interpreter/bytecode-array-iterator.cc

Issue 1612323003: Introduce {FAST,SLOW}_STRING_WRAPPER_ELEMENTS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-iterator.cc
diff --git a/src/interpreter/bytecode-array-iterator.cc b/src/interpreter/bytecode-array-iterator.cc
index b8f1dcdfec856bc3f033c57f109327e8bb313e9f..878d4999ee5f8d2689f1e8e14377f3b9936ab952 100644
--- a/src/interpreter/bytecode-array-iterator.cc
+++ b/src/interpreter/bytecode-array-iterator.cc
@@ -108,7 +108,8 @@ Register BytecodeArrayIterator::GetRegisterOperand(int operand_index) const {
Handle<Object> BytecodeArrayIterator::GetConstantForIndexOperand(
int operand_index) const {
Handle<FixedArray> constants = handle(bytecode_array()->constant_pool());
rmcilroy 2016/01/26 15:53:27 Just skip the handle creation here and call get on
Jakob Kummerow 2016/01/29 14:31:26 Most excellent point, dunno why I didn't see that
- return FixedArray::get(constants, GetIndexOperand(operand_index));
+ return FixedArray::get(*constants, GetIndexOperand(operand_index),
+ constants->GetIsolate());
}

Powered by Google App Engine
This is Rietveld 408576698