Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: Source/core/loader/appcache/ApplicationCacheHostInternal.h

Issue 161213003: Fix layering of ApplicationCacheHost (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: The real thing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 10 matching lines...) Expand all
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "WebApplicationCacheHostClient.h" 31 #include "core/frame/Frame.h"
32 #include "WebFrameClient.h"
33 #include "WebFrameImpl.h"
34 #include "core/loader/DocumentLoader.h" 32 #include "core/loader/DocumentLoader.h"
33 #include "core/loader/FrameLoader.h"
34 #include "core/loader/FrameLoaderClient.h"
35 #include "core/loader/appcache/ApplicationCacheHost.h" 35 #include "core/loader/appcache/ApplicationCacheHost.h"
36 #include "public/platform/WebApplicationCacheHostClient.h"
36 #include "public/platform/WebURL.h" 37 #include "public/platform/WebURL.h"
37 38
38 namespace WebCore { 39 namespace WebCore {
39 40
41 // FIXME: This class should go away and WebCore::ApplicationCacheHost should imp lement blink::WebApplicationCacheHostClient
40 class ApplicationCacheHostInternal FINAL : public blink::WebApplicationCacheHost Client { 42 class ApplicationCacheHostInternal FINAL : public blink::WebApplicationCacheHost Client {
41 public: 43 public:
42 ApplicationCacheHostInternal(ApplicationCacheHost* host) 44 ApplicationCacheHostInternal(ApplicationCacheHost* host)
43 : m_innerHost(host) 45 : m_innerHost(host)
44 { 46 {
45 blink::WebFrameImpl* webFrame = blink::WebFrameImpl::fromFrame(host->m_d ocumentLoader->frame()); 47 Frame* frame = host->m_documentLoader->frame();
46 ASSERT(webFrame); 48 ASSERT(frame);
47 m_outerHost = adoptPtr(webFrame->client()->createApplicationCacheHost(we bFrame, this)); 49 ASSERT(frame->loader().client());
50 m_outerHost = frame->loader().client()->createApplicationCacheHost(this) ;
48 } 51 }
49 52
50 virtual void didChangeCacheAssociation() OVERRIDE 53 virtual void didChangeCacheAssociation() OVERRIDE
51 { 54 {
52 // FIXME: Prod the inspector to update it's notion of what cache the pag e is using. 55 // FIXME: Prod the inspector to update it's notion of what cache the pag e is using.
53 } 56 }
54 57
55 virtual void notifyEventListener(blink::WebApplicationCacheHost::EventID eve ntID) OVERRIDE 58 virtual void notifyEventListener(blink::WebApplicationCacheHost::EventID eve ntID) OVERRIDE
56 { 59 {
57 m_innerHost->notifyApplicationCache(static_cast<ApplicationCacheHost::Ev entID>(eventID), 0, 0); 60 m_innerHost->notifyApplicationCache(static_cast<ApplicationCacheHost::Ev entID>(eventID), 0, 0);
(...skipping 11 matching lines...) Expand all
69 return 0; 72 return 0;
70 } 73 }
71 74
72 private: 75 private:
73 friend class ApplicationCacheHost; 76 friend class ApplicationCacheHost;
74 ApplicationCacheHost* m_innerHost; 77 ApplicationCacheHost* m_innerHost;
75 OwnPtr<blink::WebApplicationCacheHost> m_outerHost; 78 OwnPtr<blink::WebApplicationCacheHost> m_outerHost;
76 }; 79 };
77 80
78 } 81 }
OLDNEW
« no previous file with comments | « Source/core/loader/appcache/ApplicationCacheHost.cpp ('k') | Source/web/ApplicationCacheHost.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698