third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html - Issue 1611773002: bluetooth: Disconnect if the page becomes hidden or is closed.

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html

Issue 1611773002: bluetooth: Disconnect if the page becomes hidden or is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Address jyasskin's comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/connectGATT.html ('k') | third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/gc-detach.html » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothGATTRemoteServer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html b/third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html

new file mode 100644

index 0000000000000000000000000000000000000000..aa2ddec443a748670ee3d097920270cbcb7f19e0

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html

@@ -0,0 +1,30 @@

+<!DOCTYPE html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../resources/bluetooth-helpers.js"></script>

+<body>

+ <script>

+ "use strict";

+ async_test(test => {

+ window.onmessage = messageEvent => test.step(() => {

+ if (messageEvent.data === 'Ready') {

+ let iframe = document.querySelector('iframe');

+ callWithKeyDown(() => {

+ iframe.contentWindow.postMessage('Go', '*');

+ });

+ } else if (messageEvent.data === 'Connected') {

+ // Detach

+ iframe.remove();

+ // GC

+ runGarbageCollection().then(() => test.done());

+ } else {

+ assert_unreached('iframe send invalid data: ' + messageEvent.data);

Jeffrey Yasskin 2016/01/22 21:59:01 s/send/sent/ I think

ortuno 2016/01/22 22:18:14 Done.

+ }

+ });

+ testRunner.setBluetoothMockDataSet('HeartRateAdapter');

+ let iframe = document.createElement('iframe');

+ iframe.src = '../resources/disconnect-tab-in-iframe.html';

Jeffrey Yasskin 2016/01/22 21:59:01 I don't see this file. Did you forget to add it?

ortuno 2016/01/22 22:18:14 It should be connectGATT-iframe.html

+ document.body.appendChild(iframe);

+ }, 'Detach frame then garbage collect. We shouln\'t crash.');

Jeffrey Yasskin 2016/01/22 21:59:01 spelling: shouln't

ortuno 2016/01/22 22:18:14 Done. Also fixed in the other files.

+ </script>

+</body>