third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html - Issue 1611773002: bluetooth: Disconnect if the page becomes hidden or is closed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html

Issue 1611773002: bluetooth: Disconnect if the page becomes hidden or is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Address jyasskin's comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/connectGATT.html ('k') | third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/gc-detach.html » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothGATTRemoteServer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../resources/bluetooth-helpers.js"></script>

	5 <body>

	6 <script>

	7 "use strict";

	8 async_test(test => {

	9 window.onmessage = messageEvent => test.step(() => {

	10 if (messageEvent.data === 'Ready') {

	11 let iframe = document.querySelector('iframe');

	12 callWithKeyDown(() => {

	13 iframe.contentWindow.postMessage('Go', '*');

	14 });

	15 } else if (messageEvent.data === 'Connected') {

	16 // Detach

	17 iframe.remove();

	18 // GC

	19 runGarbageCollection().then(() => test.done());

	20 } else {

	21 assert_unreached('iframe send invalid data: ' + messageEvent.data);
	Jeffrey Yasskin 2016/01/22 21:59:01 s/send/sent/ I think s/send/sent/ I think ortuno 2016/01/22 22:18:14 Done. Show quoted text On 2016/01/22 21:59:01, Jeffrey Yasskin wrote: > s/send/sent/ I think Done.
	22 }

	23 });

	24 testRunner.setBluetoothMockDataSet('HeartRateAdapter');

	25 let iframe = document.createElement('iframe');

	26 iframe.src = '../resources/disconnect-tab-in-iframe.html';
	Jeffrey Yasskin 2016/01/22 21:59:01 I don't see this file. Did you forget to add it? I don't see this file. Did you forget to add it? ortuno 2016/01/22 22:18:14 It should be connectGATT-iframe.html Show quoted text On 2016/01/22 21:59:01, Jeffrey Yasskin wrote: > I don't see this file. Did you forget to add it? It should be connectGATT-iframe.html
	27 document.body.appendChild(iframe);

	28 }, 'Detach frame then garbage collect. We shouln\'t crash.');
	Jeffrey Yasskin 2016/01/22 21:59:01 spelling: shouln't spelling: shouln't ortuno 2016/01/22 22:18:14 Done. Also fixed in the other files. Show quoted text On 2016/01/22 21:59:01, Jeffrey Yasskin wrote: > spelling: shouln't Done. Also fixed in the other files.
	29 </script>

	30 </body>

OLD	NEW