Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1611693002: Revert of Don't change layout size due to top control show/hide (Closed)

Created:
4 years, 11 months ago by sgurun-gerrit only
Modified:
4 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't change layout size due to top control show/hide (patchset #13 id:240001 of https://codereview.chromium.org/1573283002/ ) Reason for revert: speculative reverts for https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/51570 see crbug/579666 Original issue's description: > Don't change layout size due to top control show/hide. > > This patch changes Chrome's top control (URL bar) behavior on Android > to match Safari's in how it affects layout size. To summarize, the > layout size or, equivalently, the initial containing block (ICB), is no > longer dynamically adjusted when the top controls are shown/hidden. > Instead the ICB is statically sized to be the size of the viewport when > top controls are showing. position: fixed elements are an exception, > they continue to work as they do today, resizing to mach the full > viewport size in response to top controls. > > Additionally, vh units were changed in a similar way; they are now also > statically sized but to the size of the viewport with top controls > hidden. > > See https://github.com/bokand/URLBarSizing for full details. > > Intent to ship: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BK0oHURgmJ4 > > BUG=428132 > > Committed: https://crrev.com/7ea490e3e6a79cc1e7fd4d952bcc36b2ad38cf40 > Cr-Commit-Position: refs/heads/master@{#370425} TBR=jbroman@chromium.org,aelias@chromium.org,bokan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428132 Committed: https://crrev.com/f656eeb17cf8de94f6c6fc10671f9a06b6c98de4 Cr-Commit-Position: refs/heads/master@{#370486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -411 lines) Patch
M third_party/WebKit/Source/core/css/CSSToLengthConversionData.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.cpp View 5 chunks +21 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 4 chunks +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TopControlsTest.cpp View 5 chunks +0 lines, -185 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/percent-height.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/vh-height.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/vh-height-width-800.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/vh-height-width-800-extra-wide.html View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sgurun-gerrit only
Created Revert of Don't change layout size due to top control show/hide
4 years, 11 months ago (2016-01-20 20:59:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611693002/1
4 years, 11 months ago (2016-01-20 20:59:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 21:01:48 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f656eeb17cf8de94f6c6fc10671f9a06b6c98de4 Cr-Commit-Position: refs/heads/master@{#370486}
4 years, 11 months ago (2016-01-20 21:03:00 UTC) #6
sgurun-gerrit only
4 years, 11 months ago (2016-01-20 22:52:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1612683002/ by sgurun@chromium.org.

The reason for reverting is: does not look like related to crbug/57966, probably
the test is flaky

relanding.

Powered by Google App Engine
This is Rietveld 408576698