bluetooth: Update BluetoothGATTCharacteristic.value on writeValue

third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/bluetooth/BluetoothGATTCharacteristic.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMDataView.h"
@@ skipping 127 matching lines @@
 {
     WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
     webbluetooth->readValue(m_webCharacteristic->characteristicInstanceID, new ReadValueCallback(this, resolver));
 
     return promise;
 }
 
+class WriteValueCallback : public WebBluetoothWriteValueCallbacks {
+public:
+    WriteValueCallback(BluetoothGATTCharacteristic* characteristic, ScriptPromiseResolver* resolver) : m_webCharacteristic(characteristic), m_resolver(resolver) {}
+
+    void onSuccess(const WebVector<uint8_t>& value) override
+    {
+        if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
+            return;
+
+        if (m_webCharacteristic) {
+            RefPtr<DOMDataView> domDataView = ConvertWebVectorToDataView(value);
+            m_webCharacteristic->setValue(domDataView);

[ortuno, 2016/01/21 16:41:32]

nit: You can just pass the result of ConvertWebVectorToDataView directly to
setValue()

+        }
+        m_resolver->resolve();
+    }
+
+    void onError(const WebBluetoothError& e) override
+    {
+        if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
+            return;
+        m_resolver->reject(BluetoothError::take(m_resolver, e));
+    }
+
+private:
+    WeakPersistent<BluetoothGATTCharacteristic> m_webCharacteristic;
+    Persistent<ScriptPromiseResolver> m_resolver;
+};
+
 ScriptPromise BluetoothGATTCharacteristic::writeValue(ScriptState* scriptState, const DOMArrayPiece& value)
 {
     WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);
     // Partial implementation of writeValue algorithm:
     // https://webbluetoothchrome.github.io/web-bluetooth/#dom-bluetoothgattcharacteristic-writevalue
 
     // If bytes is more than 512 bytes long (the maximum length of an attribute
     // value, per Long Attribute Values) return a promise rejected with an
     // InvalidModificationError and abort.
     if (value.byteLength() > 512)
         return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidModificationError, "Value can't exceed 512 bytes."));
 
     // Let valueVector be a copy of the bytes held by value.
     WebVector<uint8_t> valueVector(value.bytes(), value.byteLength());
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
 
     ScriptPromise promise = resolver->promise();
-    webbluetooth->writeValue(m_webCharacteristic->characteristicInstanceID, valueVector, new CallbackPromiseAdapter<void, BluetoothError>(resolver));
+    webbluetooth->writeValue(m_webCharacteristic->characteristicInstanceID, valueVector, new WriteValueCallback(this, resolver));
 
     return promise;
 }
 
 ScriptPromise BluetoothGATTCharacteristic::startNotifications(ScriptState* scriptState)
 {
     WebBluetooth* webbluetooth = BluetoothSupplement::fromScriptState(scriptState);
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
     webbluetooth->startNotifications(m_webCharacteristic->characteristicInstanceID, this, new CallbackPromiseAdapter<void, BluetoothError>(resolver));
@@ skipping 10 matching lines @@
 }
 
 DEFINE_TRACE(BluetoothGATTCharacteristic)
 {
     RefCountedGarbageCollectedEventTargetWithInlineData<BluetoothGATTCharacteristic>::trace(visitor);
     ActiveDOMObject::trace(visitor);
     visitor->trace(m_properties);
 }
 
 } // namespace blink