Deprecate profiler methods that accept security origin

Deprecate profiler methods that accept security origin

Now that the only known client console.profiles was removed from Blink:
https://src.chromium.org/viewvc/blink?revision=151136&view=revision
https://src.chromium.org/viewvc/blink?revision=151196&view=revision
this method can be deprecated and all the code that supports filtering
CPU profiles based on security origins can be later removed.

Drive-by fix: in line with CpuProfiler changes deprecated HeapProfiler::FindHeapSnapshot to reduce v8 API surface. FindHeapSnapshot may well be implemented based on existing GetSnapshotCount/GetSnapshot and it is only used in the tests.

BUG=None
R=jkummerow@chromium.org, loislo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14833

[alph, 2013-05-28 05:27:51]

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:325: CHECK_EQ(p1, FindCpuProfile(cpu_profiler,
uid1));
Perhaps we should keep testing the current API until we finally remove it.
Despite deprecation it may still be used.

[yurys, 2013-05-28 06:14:57]

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:325: CHECK_EQ(p1, FindCpuProfile(cpu_profiler,
uid1));
On 2013/05/28 05:27:51, alph wrote:
> Perhaps we should keep testing the current API until we finally remove it.
> Despite deprecation it may still be used. 
That would break compilation because of V8_DEPRECATED markers on the methods
being invoked from the tests.

[loislo, 2013-05-28 06:20:36]

lgtm

[alph, 2013-05-28 06:28:54]

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:325: CHECK_EQ(p1, FindCpuProfile(cpu_profiler,
uid1));
On 2013/05/28 06:14:57, Yury Semikhatsky wrote:
> On 2013/05/28 05:27:51, alph wrote:
> > Perhaps we should keep testing the current API until we finally remove it.
> > Despite deprecation it may still be used. 
> That would break compilation because of V8_DEPRECATED markers on the methods
> being invoked from the tests.

I see two ways:
1. #define V8_DISABLE_DEPRECATIONS 1 in the test.
2. Make use of
   #pragma GCC diagnostic ignored "-Wformat"
   and similar for other platforms. I'm not sure it will help though.

Well, I do not insist, you may go delete tests if all this stuff looks
overcomplicating.

[yurys, 2013-05-28 07:19:31]

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16114002/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:325: CHECK_EQ(p1, FindCpuProfile(cpu_profiler,
uid1));
On 2013/05/28 06:28:54, alph wrote:
> On 2013/05/28 06:14:57, Yury Semikhatsky wrote:
> > On 2013/05/28 05:27:51, alph wrote:
> > > Perhaps we should keep testing the current API until we finally remove it.
> > > Despite deprecation it may still be used. 
> > That would break compilation because of V8_DEPRECATED markers on the methods
> > being invoked from the tests.
> 
> I see two ways:
> 1. #define V8_DISABLE_DEPRECATIONS 1 in the test.
> 2. Make use of
>    #pragma GCC diagnostic ignored "-Wformat"
>    and similar for other platforms. I'm not sure it will help though.
> 
> Well, I do not insist, you may go delete tests if all this stuff looks
> overcomplicating.

Done #1. PTAL

[Jakob Kummerow, 2013-05-28 07:46:18]

lgtm

[yurys, 2013-05-28 08:00:26]

Committed patchset #2 manually as r14833 (presubmit successful).