Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: include/v8-profiler.h

Issue 16114002: Deprecate profiler methods that accept security origin (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: defined V8_DISABLE_DEPRECATIONS in test-cpu-profiler.cc and returned deleted test for deprecated API Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index bc50b6f42bcc36779d1c4c4eeeb65e16824a3586..d740df3bb7bd9e668666fd7a8b1360c1800c9289 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -184,19 +184,21 @@ class V8EXPORT CpuProfiler {
V8_DEPRECATED(static const CpuProfile* GetProfile(
int index,
Handle<Value> security_token = Handle<Value>()));
- /** Returns a profile by index. */
- const CpuProfile* GetCpuProfile(
+ /** Deprecated. Use GetCpuProfile with single parameter. */
+ V8_DEPRECATED(const CpuProfile* GetCpuProfile(
int index,
- Handle<Value> security_token = Handle<Value>());
+ Handle<Value> security_token));
+ /** Returns a profile by index. */
+ const CpuProfile* GetCpuProfile(int index);
/** Deprecated. Use FindProfile instead. */
V8_DEPRECATED(static const CpuProfile* FindProfile(
unsigned uid,
Handle<Value> security_token = Handle<Value>()));
/** Returns a profile by uid. */
- const CpuProfile* FindCpuProfile(
+ V8_DEPRECATED(const CpuProfile* FindCpuProfile(
unsigned uid,
- Handle<Value> security_token = Handle<Value>());
+ Handle<Value> security_token = Handle<Value>()));
/** Deprecated. Use StartCpuProfiling instead. */
V8_DEPRECATED(static void StartProfiling(Handle<String> title,
@@ -219,12 +221,16 @@ class V8EXPORT CpuProfiler {
Handle<String> title,
Handle<Value> security_token = Handle<Value>()));
/**
+ * Deprecated. Use StopCpuProfiling with one parameter instead.
+ */
+ V8_DEPRECATED(const CpuProfile* StopCpuProfiling(
+ Handle<String> title,
+ Handle<Value> security_token));
+ /**
* Stops collecting CPU profile with a given title and returns it.
* If the title given is empty, finishes the last profile started.
*/
- const CpuProfile* StopCpuProfiling(
- Handle<String> title,
- Handle<Value> security_token = Handle<Value>());
+ const CpuProfile* StopCpuProfiling(Handle<String> title);
/** Deprecated. Use DeleteAllCpuProfiles instead. */
V8_DEPRECATED(static void DeleteAllProfiles());
@@ -438,7 +444,7 @@ class V8EXPORT HeapProfiler {
/** Deprecated. Use FindHeapSnapshot instead. */
V8_DEPRECATED(static const HeapSnapshot* FindSnapshot(unsigned uid));
/** Returns a profile by uid. */
- const HeapSnapshot* FindHeapSnapshot(unsigned uid);
+ V8_DEPRECATED(const HeapSnapshot* FindHeapSnapshot(unsigned uid));
/** Deprecated. Use GetObjectId instead. */
V8_DEPRECATED(static SnapshotObjectId GetSnapshotObjectId(
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698