Treat bad values passed to --images as a fatal error

Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004

Committed: https://skia.googlesource.com/skia/+/8673714d75ff1020f78217ff8839f1e18c3591e4

[scroggo, 2016-01-22 15:29:08]

Description was changed from

==========
Make DM exit when passed a bad images directory

If a user (or more importantly, a bot) finds no images in a directory
passed to --images, assume this is an error and return, so they can
supply a valid directory instead.
==========

to

==========
Make DM exit when passed a bad images directory

If a user (or more importantly, a bot) finds no images in a directory
passed to --images, assume this is an error and return, so they can
supply a valid directory instead.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-22 15:50:27]

Description was changed from

==========
Make DM exit when passed a bad images directory

If a user (or more importantly, a bot) finds no images in a directory
passed to --images, assume this is an error and return, so they can
supply a valid directory instead.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make DM/nanobench exit when passed an images directory w/o images

If a user (or more importantly, a bot) finds no images in a directory
passed to --images, assume this is an error and return, so they can
supply a valid directory instead.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-22 17:51:15]

Description was changed from

==========
Make DM/nanobench exit when passed an images directory w/o images

If a user (or more importantly, a bot) finds no images in a directory
passed to --images, assume this is an error and return, so they can
supply a valid directory instead.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-22 17:53:41]

Description was changed from

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-22 17:54:59]

scroggo@google.com changed reviewers:
+ borenet@google.com, msarett@google.com, mtklein@google.com

[scroggo, 2016-01-22 17:54:59]

Adding:
- Eric, who requested the feature
- Mike, for input on DM/nanobench
- Matt, for thoughts on images

https://codereview.chromium.org/1611323004/diff/100001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1611323004/diff/100001/dm/DM.cpp#newcode532
dm/DM.cpp:532: if (brd_supported(ext)) {
This behavior is slightly different. We used to only check brd_supported when
looking through a directory. Now we do when looking at an individual image. I
think the new behavior is better.

[mtklein, 2016-01-22 18:05:15]

https://codereview.chromium.org/1611323004/diff/120001/tools/flags/SkCommonFl...
File tools/flags/SkCommonFlags.h (right):

https://codereview.chromium.org/1611323004/diff/120001/tools/flags/SkCommonFl...
tools/flags/SkCommonFlags.h:34: namespace SkCommonFlags {
I don't this needs a namespace or an SkPrefix.  We're not shipping this code as
part of Skia.

CollectImages is just fine.

https://codereview.chromium.org/1611323004/diff/120001/tools/flags/SkCommonFl...
tools/flags/SkCommonFlags.h:41: *  type), this will exit the program, so the
user or bot can rerun using the correct directory.
Let's have it return false rather than exiting.
It'd be a little more comforting to see the exit-on-failure explicitly written
out in each of DM/nanobench's main functions.

If that can't work, we'd better name this something like collectImagesOrDie().

[mtklein, 2016-01-22 18:05:46]

> I don't* this needs a namespace or an SkPrefix.  We're not shipping this code
as
> part of Skia.
*think

[scroggo, 2016-01-27 15:43:23]

Description was changed from

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

Only consider image paths ending in RAW suffixes as images if
SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure
to decode errors on platforms that cannot decode it.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-27 15:43:38]

https://codereview.chromium.org/1611323004/diff/120001/tools/flags/SkCommonFl...
File tools/flags/SkCommonFlags.h (right):

https://codereview.chromium.org/1611323004/diff/120001/tools/flags/SkCommonFl...
tools/flags/SkCommonFlags.h:34: namespace SkCommonFlags {
On 2016/01/22 18:05:15, mtklein wrote:
> I don't this needs a namespace or an SkPrefix.  We're not shipping this code
as
> part of Skia.
> 
> CollectImages is just fine.

Done.

https://codereview.chromium.org/1611323004/diff/120001/tools/flags/SkCommonFl...
tools/flags/SkCommonFlags.h:41: *  type), this will exit the program, so the
user or bot can rerun using the correct directory.
On 2016/01/22 18:05:15, mtklein wrote:
> Let's have it return false rather than exiting.
> It'd be a little more comforting to see the exit-on-failure explicitly written
> out in each of DM/nanobench's main functions.
> 
> If that can't work, we'd better name this something like collectImagesOrDie().

Done.

https://codereview.chromium.org/1611323004/diff/180001/dm/DM.cpp
File dm/DM.cpp (left):

https://codereview.chromium.org/1611323004/diff/180001/dm/DM.cpp#oldcode522
dm/DM.cpp:522: static bool is_raw(const SkString& file) {
This was only here to prevent testing RAW with SkImageDecoder. I have simplified
this by not testing SkImageDecoder at all (see crrev.com/1641663002).

https://codereview.chromium.org/1611323004/diff/180001/tools/flags/SkCommonFl...
File tools/flags/SkCommonFlags.cpp (right):

https://codereview.chromium.org/1611323004/diff/180001/tools/flags/SkCommonFl...
tools/flags/SkCommonFlags.cpp:60: #ifdef SK_CODEC_DECODES_RAW
This could go in its own CL, but I'm moving it anyway. This is necessary to
start testing RAW (i.e. before we land crrev.com/1612113002)

[msarett, 2016-01-27 16:17:56]

"- Matt, for thoughts on images"

Image related changes look good to me.

[mtklein, 2016-01-27 19:38:06]

tools lgtm

https://codereview.chromium.org/1611323004/diff/260001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1611323004/diff/260001/dm/DM.cpp#newcode1104
dm/DM.cpp:1104: exit(1);
return 1?

[scroggo, 2016-01-27 19:42:27]

https://codereview.chromium.org/1611323004/diff/260001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1611323004/diff/260001/dm/DM.cpp#newcode1104
dm/DM.cpp:1104: exit(1);
On 2016/01/27 19:38:05, mtklein wrote:
> return 1?

Done.

https://codereview.chromium.org/1611323004/diff/300001/gyp/codec.gyp
File gyp/codec.gyp (left):

https://codereview.chromium.org/1611323004/diff/300001/gyp/codec.gyp#oldcode114
gyp/codec.gyp:114: 'SK_CODEC_DECODES_RAW',
This is now defined everywhere, so it can be shared by flags.

https://codereview.chromium.org/1611323004/diff/300001/gyp/codec.gyp
File gyp/codec.gyp (right):

https://codereview.chromium.org/1611323004/diff/300001/gyp/codec.gyp#newcode70
gyp/codec.gyp:70: ['skia_codec_decodes_raw', {
Now this flag is only true on platforms where it's supported, rather than being
part of the picture.

https://codereview.chromium.org/1611323004/diff/300001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/1611323004/diff/300001/gyp/common_variables.g...
gyp/common_variables.gypi:63: ['skia_os == "chromeos"', {
Once chromeos supports RAW, this can go back to the older file, which is
simpler, but this will allow us to start testing in case the chromeos fix takes
some more time.

[scroggo, 2016-01-28 16:25:35]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-01-28 16:25:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1611323004/#ps320001
(title: "exit -> return")

[commit-bot: I haz the power, 2016-01-28 16:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611323004/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611323004/320001

[commit-bot: I haz the power, 2016-01-28 16:41:12]

Description was changed from

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

Only consider image paths ending in RAW suffixes as images if
SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure
to decode errors on platforms that cannot decode it.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

Only consider image paths ending in RAW suffixes as images if
SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure
to decode errors on platforms that cannot decode it.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93
==========

[commit-bot: I haz the power, 2016-01-28 16:41:13]

Committed patchset #17 (id:320001) as
https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93

[scroggo, 2016-01-29 22:17:38]

A revert of this CL (patchset #17 id:320001) has been created in
https://codereview.chromium.org/1653543002/ by scroggo@google.com.

The reason for reverting is: Speculative to fix windows bots.

[scroggo, 2016-02-01 17:53:30]

Description was changed from

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

Only consider image paths ending in RAW suffixes as images if
SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure
to decode errors on platforms that cannot decode it.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93
==========

to

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

Only consider image paths ending in RAW suffixes as images if
SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure
to decode errors on platforms that cannot decode it.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93
==========

[scroggo, 2016-02-03 16:43:43]

Description was changed from

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

Only consider image paths ending in RAW suffixes as images if
SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure
to decode errors on platforms that cannot decode it.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93
==========

to

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-02-03 19:57:34]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-02-03 19:57:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1611323004/#ps340001
(title: "Rebase; remove DNG specific changes")

[commit-bot: I haz the power, 2016-02-03 19:57:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611323004/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611323004/340001

[commit-bot: I haz the power, 2016-02-03 20:19:14]

Description was changed from

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Treat bad values passed to --images as a fatal error

If an option is passed to --images that is either a non-existent path or
a folder with no images matching the supported types, assume this is
an error and exit, so they can supply a valid path instead.

Share code between DM and nanobench in SkCommonFlags.

nanobench now behaves more like DM - it will check a directory for
images that match the supported extensions.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8673714d75ff1020f78217ff8839f1e18c3591e4
==========

[commit-bot: I haz the power, 2016-02-03 20:19:15]

Committed patchset #18 (id:340001) as
https://skia.googlesource.com/skia/+/8673714d75ff1020f78217ff8839f1e18c3591e4