Treat bad values passed to --images as a fatal error

gyp/codec.gyp

 # Copyright 2015 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 # Copyright 2015 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # GYP file for codec project.
@@ skipping 49 matching lines @@
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           '../include/codec',
         ],
       },
       'defines': [
         'TURBO_HAS_SKIP',
       ],
       'conditions': [
-        # FIXME: fix the support for ChromeOS [DNG SDK issue with clock_gettime()].
-        ['skia_codec_decodes_raw and skia_os != "chromeos"', {
+        ['skia_codec_decodes_raw', {

[scroggo, 2016/01/27 19:42:27]

Now this flag is only true on platforms where it's supported, rather than being
part of the picture.

           'dependencies': [
             'raw_codec',
           ],
         },],
       ],
     }, {
       # RAW codec needs exceptions. Due to that, it is a separate target. Its usage can be
-      # controlled by SK_CODEC_DECODES_RAW flag.
+      # controlled by skia_codec_decodes_raw flag.
       'target_name': 'raw_codec',
       'product_name': 'raw_codec',
       'type': 'static_library',
       'dependencies': [
         'core.gyp:*',
         'dng_sdk.gyp:dng_sdk-selector',
         'libjpeg-turbo-selector.gyp:libjpeg-turbo-selector',
         'piex.gyp:piex-selector',
       ],
       'cflags':[
@@ skipping 13 matching lines @@
         '../src/core',
       ],
       'sources': [
         '../src/codec/SkRawAdapterCodec.cpp',
         '../src/codec/SkRawCodec.cpp',
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           '../include/codec',
         ],
-        'defines': [
-          'SK_CODEC_DECODES_RAW',

[scroggo, 2016/01/27 19:42:27]

This is now defined everywhere, so it can be shared by flags.

-        ],
       },
-      'defines': [
-        'SK_CODEC_DECODES_RAW',
-      ],
       'conditions': [
         ['skia_arch_type == "x86" or skia_arch_type == "arm"', {
           'defines': [
             'qDNGBigEndian=0',
           ],
         }],
         ['skia_os == "ios" or skia_os == "mac"', {
           'xcode_settings': {
             'OTHER_CFLAGS': ['-fexceptions'],
             'OTHER_CPLUSPLUSFLAGS': ['-fexceptions'],
           },
         }],
       ],
     },
   ],
 }