Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1611313003: Revert of Array length reduction should throw in strict mode if it can't delete an element. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Array length reduction should throw in strict mode if it can't delete an element. (patchset #7 id:220001 of https://codereview.chromium.org/1587073003/ ) Reason for revert: [Sheriff] Breaks layout tests. Please fix upstream. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/4077 Original issue's description: > Array length reduction should throw in strict mode if it can't delete an element. > > When accessor getter callback is called the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according to ES6 there's no difference between strict and non-strict property loads. For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true if the property is set in strict context. > > Interceptors follow same idea: for getter, enumerator and query callbacks the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true in strict context. > > This CL also cleans up the CallApiGetterStub and removes bogus asserts from [arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers containing duplicates. > > BUG=v8:4267 > LOG=Y > > Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f > Cr-Commit-Position: refs/heads/master@{#33438} TBR=verwaest@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4267 Committed: https://crrev.com/575e90c1d02c91f1260155cfa63d315d47b8b078 Cr-Commit-Position: refs/heads/master@{#33444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -658 lines) Patch
M include/v8.h View 2 chunks +7 lines, -15 lines 0 comments Download
M src/accessors.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/arguments.h View 1 chunk +5 lines, -7 lines 0 comments Download
M src/arguments.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +12 lines, -17 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 4 chunks +4 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +10 lines, -16 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +15 lines, -27 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 3 chunks +23 lines, -26 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 4 chunks +23 lines, -17 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 4 chunks +14 lines, -18 lines 0 comments Download
M src/ic/ic.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 3 chunks +28 lines, -39 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 3 chunks +28 lines, -39 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 3 chunks +23 lines, -27 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 4 chunks +17 lines, -22 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 4 chunks +14 lines, -18 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +11 lines, -17 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +11 lines, -18 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 12 chunks +11 lines, -22 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +11 lines, -16 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +21 lines, -22 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +15 lines, -27 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D test/mjsunit/regress/regress-4267.js View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Array length reduction should throw in strict mode if it can't delete ...
4 years, 11 months ago (2016-01-21 18:53:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611313003/1
4 years, 11 months ago (2016-01-21 18:53:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 18:54:13 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 18:54:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/575e90c1d02c91f1260155cfa63d315d47b8b078
Cr-Commit-Position: refs/heads/master@{#33444}

Powered by Google App Engine
This is Rietveld 408576698