Enable Oilpan on ToT

Enable Oilpan on ToT

PSA in blink-dev@: https://groups.google.com/a/chromium.org/d/topic/blink-dev/3qqNXdA1jUM/discussion

This CL enables Oilpan on ToT. I'll revert the CL once any unacceptable stability issue is observed.
This CL also merges OilpanExpectations into TestExpectations.

BUG=553613
Committed: https://crrev.com/b25744bcc43fc02389cb7e5e2a59a050c05a9386
Cr-Commit-Position: refs/heads/master@{#371208}

[haraken, 2016-01-22 23:00:12]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[haraken, 2016-01-22 23:00:13]

PTAL

I'm planning to land this on Jan 25 JST if there is no objection in blink-dev@.

[haraken, 2016-01-23 14:23:59]

It seems that the memory leak detected in the linux_chromium_asan_rel_ng is a
real one.

The leak does not happen without oilpan:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

[sof, 2016-01-23 14:31:47]

On 2016/01/23 14:23:59, haraken wrote:
> It seems that the memory leak detected in the linux_chromium_asan_rel_ng is a
> real one.
> 
> The leak does not happen without oilpan:
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

Probably needs a variation of https://codereview.chromium.org/1495923002 to
avoid.

[sof, 2016-01-23 14:33:08]

On 2016/01/23 14:31:47, sof wrote:
> On 2016/01/23 14:23:59, haraken wrote:
> > It seems that the memory leak detected in the linux_chromium_asan_rel_ng is
a
> > real one.
> > 
> > The leak does not happen without oilpan:
> >
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> 
> Probably needs a variation of https://codereview.chromium.org/1495923002 to
> avoid.

I can kick off an LSan build in the background, and take a look..

[sof, 2016-01-23 19:36:21]

On 2016/01/23 14:33:08, sof wrote:
> On 2016/01/23 14:31:47, sof wrote:
> > On 2016/01/23 14:23:59, haraken wrote:
> > > It seems that the memory leak detected in the linux_chromium_asan_rel_ng
is
> a
> > > real one.
> > > 
> > > The leak does not happen without oilpan:
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> > 
> > Probably needs a variation of https://codereview.chromium.org/1495923002 to
> > avoid.
> 
> I can kick off an LSan build in the background, and take a look..

https://codereview.chromium.org/1621823004/ takes care of it in somewhat
structured fashion, I hope -- test results:
https://codereview.chromium.org/1517193002/#ps220001

[sof, 2016-01-23 19:46:42]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-01-23 19:46:43]

https://codereview.chromium.org/1611303006/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1611303006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:1: # ====== Oilpan-only failures
from here ======
Sounds worrisome - add something like,

 Most of these actually cause the tests to report success, rather than failure.
Expected outputs will be adjusted for the better once Oilpan has been well and
truly enabled always.

i.e., we're not introducing breakage in behavior here.

[sof, 2016-01-24 17:48:45]

linux_chromium_asan_rel_ng is green following r371169.

[haraken, 2016-01-24 23:39:41]

On 2016/01/23 19:46:43, sof wrote:
>
https://codereview.chromium.org/1611303006/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/1611303006/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/TestExpectations:1: # ====== Oilpan-only
failures
> from here ======
> Sounds worrisome - add something like,
> 
>  Most of these actually cause the tests to report success, rather than
failure.
> Expected outputs will be adjusted for the better once Oilpan has been well and
> truly enabled always.
> 
> i.e., we're not introducing breakage in behavior here.

Done.

[haraken, 2016-01-24 23:41:46]

haraken@chromium.org changed reviewers:
+ tkent@chromium.org

[haraken, 2016-01-24 23:41:46]

tkent@: Would you take a look at public/?

(I'll land this once Sigbjorn stamps it.)

[tkent, 2016-01-24 23:46:54]

lgtm

[haraken, 2016-01-25 01:39:08]

Now all bots are green.

Sigbjorn: PTAL.

[sof, 2016-01-25 06:19:08]

lgtm from here also.

[haraken, 2016-01-25 06:29:17]

Let me land this.

[haraken, 2016-01-25 06:29:23]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-01-25 06:29:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611303006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611303006/40001

[commit-bot: I haz the power, 2016-01-25 06:37:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 06:37:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-01-25 06:46:13]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-01-25 06:46:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/1611303006/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-25 06:46:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611303006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611303006/60001

[commit-bot: I haz the power, 2016-01-25 09:05:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-25 09:06:32]

Description was changed from

==========
Enable Oilpan on ToT

PSA in blink-dev@:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/3qqNXdA1jUM/discus...

This CL enables Oilpan on ToT. I'll revert the CL once any unacceptable
stability issue is observed.
This CL also moves contents of OilpanExpectations into TestExpectations.

BUG=553613
==========

to

==========
Enable Oilpan on ToT

PSA in blink-dev@:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/3qqNXdA1jUM/discus...

This CL enables Oilpan on ToT. I'll revert the CL once any unacceptable
stability issue is observed.
This CL also moves contents of OilpanExpectations into TestExpectations.

BUG=553613

Committed: https://crrev.com/b25744bcc43fc02389cb7e5e2a59a050c05a9386
Cr-Commit-Position: refs/heads/master@{#371208}
==========

[commit-bot: I haz the power, 2016-01-25 09:06:33]

Patchset 4 (id:??) landed as
https://crrev.com/b25744bcc43fc02389cb7e5e2a59a050c05a9386
Cr-Commit-Position: refs/heads/master@{#371208}

[haraken, 2016-01-25 09:23:33]

Description was changed from

==========
Enable Oilpan on ToT

PSA in blink-dev@:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/3qqNXdA1jUM/discus...

This CL enables Oilpan on ToT. I'll revert the CL once any unacceptable
stability issue is observed.
This CL also moves contents of OilpanExpectations into TestExpectations.

BUG=553613

Committed: https://crrev.com/b25744bcc43fc02389cb7e5e2a59a050c05a9386
Cr-Commit-Position: refs/heads/master@{#371208}
==========

to

==========
Enable Oilpan on ToT

PSA in blink-dev@:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/3qqNXdA1jUM/discus...

This CL enables Oilpan on ToT. I'll revert the CL once any unacceptable
stability issue is observed.
This CL also merges OilpanExpectations into TestExpectations.

BUG=553613

Committed: https://crrev.com/b25744bcc43fc02389cb7e5e2a59a050c05a9386
Cr-Commit-Position: refs/heads/master@{#371208}
==========