Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1495923002: Prevent reported RenderViewImplTest LSan leaks. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent reported RenderViewImplTest LSan leaks. Add missing calls to ProcessPendingMessages() to a pair of RenderViewImplTest unit tests. Not doing so would, with Oilpan enabled, flakily hold on to the entire view of the test and report it as leaking with LSan. R=jochen BUG= Committed: https://crrev.com/27aa758d2e79c27b8c98accbc749e0858e212627 Cr-Commit-Position: refs/heads/master@{#363196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/render_view_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
please take a look. Came across this issue while making Oilpan and LSan work better ...
5 years ago (2015-12-03 14:56:05 UTC) #2
haraken
LGTM
5 years ago (2015-12-03 15:03:11 UTC) #3
sof
On 2015/12/03 15:03:11, haraken wrote: > LGTM thanks; owner approval needed, jochen@ ptal?
5 years ago (2015-12-03 15:36:41 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-04 13:15:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495923002/1
5 years ago (2015-12-04 13:32:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 13:36:41 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-04 13:37:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27aa758d2e79c27b8c98accbc749e0858e212627
Cr-Commit-Position: refs/heads/master@{#363196}

Powered by Google App Engine
This is Rietveld 408576698