Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: content/renderer/render_view_impl.cc

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 296fce9e06f6a6751b3725844e23a1704727bbc1..22cb53a810934b689feb1194d6dea9117e385c1e 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1843,10 +1843,6 @@ bool RenderViewImpl::enumerateChosenDirectory(
}
void RenderViewImpl::didStartLoading(bool to_different_document) {
- didStartLoading();
-}
-
-void RenderViewImpl::didStartLoading() {
if (is_loading_) {
DVLOG(1) << "didStartLoading called while loading";
return;
@@ -1855,7 +1851,7 @@ void RenderViewImpl::didStartLoading() {
is_loading_ = true;
// Send the IPC message through the top-level frame.
- main_render_frame_->didStartLoading();
+ main_render_frame_->didStartLoading(to_different_document);
FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidStartLoading());
}
@@ -3261,7 +3257,7 @@ void RenderViewImpl::RunModalAlertDialog(blink::WebFrame* frame,
}
void RenderViewImpl::DidStartLoading() {
- didStartLoading();
+ didStartLoading(true);
}
void RenderViewImpl::DidStopLoading() {

Powered by Google App Engine
This is Rietveld 408576698