Fix pushState causing stop/reload button and favicon to flicker.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 1825 matching lines @@
     WebFileChooserCompletion* chooser_completion) {
   int id = enumeration_completion_id_++;
   enumeration_completions_[id] = chooser_completion;
   return Send(new ViewHostMsg_EnumerateDirectory(
       routing_id_,
       id,
       base::FilePath::FromUTF16Unsafe(path)));
 }
 
 void RenderViewImpl::didStartLoading(bool to_different_document) {
-  didStartLoading();
-}
-
-void RenderViewImpl::didStartLoading() {
   if (is_loading_) {
     DVLOG(1) << "didStartLoading called while loading";
     return;
   }
 
   is_loading_ = true;
 
   // Send the IPC message through the top-level frame.
-  main_render_frame_->didStartLoading();
+  main_render_frame_->didStartLoading(to_different_document);
 
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidStartLoading());
 }
 
 void RenderViewImpl::didStopLoading() {
   if (!is_loading_) {
     DVLOG(1) << "DidStopLoading called while not loading";
     return;
   }
 
@@ skipping 1385 matching lines @@
 blink::WebPageVisibilityState RenderViewImpl::GetVisibilityState() const {
   return visibilityState();
 }
 
 void RenderViewImpl::RunModalAlertDialog(blink::WebFrame* frame,
                                          const blink::WebString& message) {
   return runModalAlertDialog(frame, message);
 }
 
 void RenderViewImpl::DidStartLoading() {
-  didStartLoading();
+  didStartLoading(true);
 }
 
 void RenderViewImpl::DidStopLoading() {
   didStopLoading();
 }
 
 void RenderViewImpl::DidPlay(blink::WebMediaPlayer* player) {
   Send(new ViewHostMsg_MediaPlayingNotification(routing_id_,
                                                 reinterpret_cast<int64>(player),
                                                 player->hasVideo(),
@@ skipping 1882 matching lines @@
   for (size_t i = 0; i < icon_urls.size(); i++) {
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content