Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1610993003: Rename ShadowDistributed to ShadowV0Distributed (Closed)

Created:
4 years, 11 months ago by kochi
Modified:
4 years, 11 months ago
Reviewers:
yosin_UTC9, rune
CC:
blink-reviews, chromium-reviews, hayato, rune
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ShadowDistributed to ShadowV0Distributed There are other places which "shadow distributed" is used (e.g. css/RuleSet.h), and those are renamed to "content pseudo" etc. in https://codereview.chromium.org/1616743002/ For these tests in editing, renaming it to "ShadowV0" should make more sense because it is tested against V0 distributed node (i.e. <content>). This is a name-only change and no functionality/test difference. BUG=531990 Committed: https://crrev.com/103420cd626f0b9fbc7f57c8b85f14e56e301abf Cr-Commit-Position: refs/heads/master@{#370656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
kochi
PTAL
4 years, 11 months ago (2016-01-21 07:19:59 UTC) #3
rune
lgtm
4 years, 11 months ago (2016-01-21 08:05:13 UTC) #5
yosin_UTC9
lgtm Make sense about term "ShadowDOMV0"
4 years, 11 months ago (2016-01-21 08:15:16 UTC) #6
yosin_UTC9
On 2016/01/21 at 08:15:16, Yosi_UTC9 wrote: > lgtm > > Make sense about term "ShadowDOMV0" ...
4 years, 11 months ago (2016-01-21 08:16:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610993003/1
4 years, 11 months ago (2016-01-21 08:55:40 UTC) #9
kochi
On 2016/01/21 08:16:51, Yosi_UTC9 wrote: > On 2016/01/21 at 08:15:16, Yosi_UTC9 wrote: > > lgtm ...
4 years, 11 months ago (2016-01-21 09:00:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 09:55:55 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 09:56:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/103420cd626f0b9fbc7f57c8b85f14e56e301abf
Cr-Commit-Position: refs/heads/master@{#370656}

Powered by Google App Engine
This is Rietveld 408576698