Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: common/logdog/butlerproto/proto_test.go

Issue 1610993002: LogDog: Add collector service implementation. (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/logdog/butlerproto/proto_test.go
diff --git a/common/logdog/butlerproto/proto_test.go b/common/logdog/butlerproto/proto_test.go
index 0e362dba99875c2f0838944741ddabbad792afd1..8de810723f89233c1e8082300e769f4bef04a14a 100644
--- a/common/logdog/butlerproto/proto_test.go
+++ b/common/logdog/butlerproto/proto_test.go
@@ -82,15 +82,14 @@ func TestReader(t *testing.T) {
So(err, assertions.ShouldErrLike, "unknown data type")
})
- Convey(`Will fail to read if an unknown protocol version is identified.`, func() {
+ Convey(`Will not decode contents if an unknown protocol version is identified.`, func() {
// Assert that we are testing an unknown type.
md.ProtoVersion = "DEFINITELY NOT VALID"
push(&md)
push(&bundle)
- err := r.Read(&buf)
- So(err, ShouldNotBeNil)
- So(err, assertions.ShouldErrLike, "unknown protobuf version")
+ So(r.Read(&buf), ShouldBeNil)
+ So(r.Bundle, ShouldBeNil)
})
Convey(`Will fail to read junk metadata.`, func() {

Powered by Google App Engine
This is Rietveld 408576698