LogDog: Add collector service implementation.

common/logdog/butlerproto/proto_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package butlerproto
 
 import (
         "bytes"
         "io"
         "strings"
@@ skipping 64 matching lines @@
                         So(protocol.ButlerMetadata_ContentType_name[int32(unknownType)], ShouldEqual, "")
 
                         md.Type = unknownType
                         push(&md)
 
                         err := r.Read(&buf)
                         So(err, ShouldNotBeNil)
                         So(err, assertions.ShouldErrLike, "unknown data type")
                 })
 
-                Convey(`Will fail to read if an unknown protocol version is identified.`, func() {
+                Convey(`Will not decode contents if an unknown protocol version is identified.`, func() {
                         // Assert that we are testing an unknown type.
                         md.ProtoVersion = "DEFINITELY NOT VALID"
                         push(&md)
                         push(&bundle)
 
-                        err := r.Read(&buf)
-                        So(err, ShouldNotBeNil)
-                        So(err, assertions.ShouldErrLike, "unknown protobuf version")
+                        So(r.Read(&buf), ShouldBeNil)
+                        So(r.Bundle, ShouldBeNil)
                 })
 
                 Convey(`Will fail to read junk metadata.`, func() {
                         So(writeFrame([]byte{0xd0, 0x6f, 0x00, 0xd5}), ShouldBeNil)
 
                         err := r.Read(&buf)
                         So(err, ShouldNotBeNil)
                         So(err, assertions.ShouldErrLike, "failed to unmarshal Metadata frame")
                 })
 
@@ skipping 108 matching lines @@
                                         r, err := read(&buf)
                                         So(err, ShouldBeNil)
                                         So(r.Metadata.Compression, ShouldEqual, protocol.ButlerMetadata_ZLIB)
                                         So(r.Bundle.Source, ShouldEqual, bundle.Source)
                                         So(r.Metadata.ProtoVersion, ShouldEqual, protocol.Version)
                                 })
                         })
                 })
         })
 }