Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1610943002: Disable QUIC when a connection timesout with open streams by setting threshold value to 1 when flag… (Closed)

Created:
4 years, 11 months ago by Zhongyi Shi
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@DISABLE_QUIC_WHEN_CONNECTION_TIMEOUT
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable QUIC when a connection timesout with open streams by setting threshold value to 1 when flag is set. BUG=571098 Committed: https://crrev.com/89649c3db1ff298b0ab7f687edd9858815201558 Cr-Commit-Position: refs/heads/master@{#370843}

Patch Set 1 #

Patch Set 2 : fix a typo, add unittest #

Total comments: 2

Patch Set 3 : param name change #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M net/http/http_network_session.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 4 chunks +65 lines, -2 lines 1 comment Download

Depends on Patchset:

Issue 1603203002 Patch 40001

Messages

Total messages: 10 (3 generated)
Zhongyi Shi
4 years, 11 months ago (2016-01-21 00:16:02 UTC) #2
Ryan Hamilton
need to do the rename as per my comments on the other CL, of course. ...
4 years, 11 months ago (2016-01-21 15:12:31 UTC) #3
Zhongyi Shi
https://codereview.chromium.org/1610943002/diff/20001/net/quic/quic_stream_factory_test.cc File net/quic/quic_stream_factory_test.cc (right): https://codereview.chromium.org/1610943002/diff/20001/net/quic/quic_stream_factory_test.cc#newcode2810 net/quic/quic_stream_factory_test.cc:2810: session->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false); On 2016/01/21 15:12:31, Ryan Hamilton wrote: > ...
4 years, 11 months ago (2016-01-21 19:55:21 UTC) #4
Ryan Hamilton
lgtm https://codereview.chromium.org/1610943002/diff/40001/net/quic/quic_stream_factory_test.cc File net/quic/quic_stream_factory_test.cc (right): https://codereview.chromium.org/1610943002/diff/40001/net/quic/quic_stream_factory_test.cc#newcode2810 net/quic/quic_stream_factory_test.cc:2810: session->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false); Hah! I missed this. Nice!
4 years, 11 months ago (2016-01-21 21:08:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610943002/40001
4 years, 11 months ago (2016-01-21 22:49:17 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-22 00:14:08 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 00:14:58 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/89649c3db1ff298b0ab7f687edd9858815201558
Cr-Commit-Position: refs/heads/master@{#370843}

Powered by Google App Engine
This is Rietveld 408576698