Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1603203002: Add a finch trial param to disable QUIC when connection times out with open streams (Closed)

Created:
4 years, 11 months ago by Zhongyi Shi
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a finch trial param to disable QUIC when connection times out with open streams BUG=571098 Committed: https://crrev.com/75527dd8d63cb75a5b6b69dda1b57cfa20d5a7b1 Cr-Commit-Position: refs/heads/master@{#370806}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : param name change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M chrome/browser/io_thread.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1610943002 Patch 40001

Messages

Total messages: 11 (4 generated)
Zhongyi Shi
4 years, 11 months ago (2016-01-21 00:15:43 UTC) #3
Ryan Hamilton
Looks good, modulo one minor naming nit. https://codereview.chromium.org/1603203002/diff/20001/net/http/http_network_session.h File net/http/http_network_session.h (right): https://codereview.chromium.org/1603203002/diff/20001/net/http/http_network_session.h#newcode125 net/http/http_network_session.h:125: bool disable_quic_when_connection_times_out_with_open_streams; ...
4 years, 11 months ago (2016-01-21 15:11:09 UTC) #4
Zhongyi Shi
Thanks for the suggestion, PTAL. https://codereview.chromium.org/1603203002/diff/20001/net/http/http_network_session.h File net/http/http_network_session.h (right): https://codereview.chromium.org/1603203002/diff/20001/net/http/http_network_session.h#newcode125 net/http/http_network_session.h:125: bool disable_quic_when_connection_times_out_with_open_streams; On 2016/01/21 ...
4 years, 11 months ago (2016-01-21 19:43:54 UTC) #5
Ryan Hamilton
lgtm
4 years, 11 months ago (2016-01-21 21:08:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603203002/40001
4 years, 11 months ago (2016-01-21 21:10:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-21 22:26:53 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 22:28:02 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/75527dd8d63cb75a5b6b69dda1b57cfa20d5a7b1
Cr-Commit-Position: refs/heads/master@{#370806}

Powered by Google App Engine
This is Rietveld 408576698