Oilpan: ImageObserver needs to be a GC mixin.

third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 #include "platform/SharedBuffer.h"
 #include "platform/graphics/DeferredImageDecoder.h"
 #include "platform/graphics/ImageObserver.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 class BitmapImageTest : public ::testing::Test {
 public:
-    class FakeImageObserver : public ImageObserver {
+    class FakeImageObserver : public NoBaseWillBeGarbageCollectedFinalized<FakeImageObserver>, public ImageObserver {
+        WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(FakeImageObserver);
     public:
         FakeImageObserver() : m_lastDecodedSizeChangedDelta(0) { }
 
         virtual void decodedSizeChanged(const Image*, int delta)
         {
             m_lastDecodedSizeChangedDelta = delta;
         }
         void didDraw(const Image*) override { }
         bool shouldPauseAnimation(const Image*) override { return false; }
         void animationAdvanced(const Image*) override { }
@@ skipping 62 matching lines @@
 
     PassRefPtr<Image> imageForDefaultFrame()
     {
         return m_image->imageForDefaultFrame();
     }
 
 protected:
     void SetUp() override
     {
         DeferredImageDecoder::setEnabled(m_enableDeferredDecoding);
-        m_image = BitmapImage::create(&m_imageObserver);
+        m_imageObserver = adoptPtrWillBeNoop(new FakeImageObserver);
+        m_image = BitmapImage::create(m_imageObserver.get());
     }
 
-    FakeImageObserver m_imageObserver;
+    OwnPtrWillBePersistent<FakeImageObserver> m_imageObserver;
     RefPtr<BitmapImage> m_image;
 
 private:
     bool m_enableDeferredDecoding;
 };
 
 TEST_F(BitmapImageTest, destroyDecodedDataExceptCurrentFrame)
 {
     loadImage("/LayoutTests/fast/images/resources/animated-10color.gif");
     size_t totalSize = decodedSize();
     size_t frame = frameCount() / 2;
     setCurrentFrame(frame);
     size_t size = frameDecodedSize(frame);
     destroyDecodedData(false);
-    EXPECT_LT(m_imageObserver.m_lastDecodedSizeChangedDelta, 0);
-    EXPECT_GE(m_imageObserver.m_lastDecodedSizeChangedDelta, -static_cast<int>(totalSize - size));
+    EXPECT_LT(m_imageObserver->m_lastDecodedSizeChangedDelta, 0);
+    EXPECT_GE(m_imageObserver->m_lastDecodedSizeChangedDelta, -static_cast<int>(totalSize - size));
 }
 
 TEST_F(BitmapImageTest, destroyAllDecodedData)
 {
     loadImage("/LayoutTests/fast/images/resources/animated-10color.gif");
     size_t totalSize = decodedSize();
     EXPECT_GT(totalSize, 0u);
     destroyDecodedData(true);
-    EXPECT_EQ(-static_cast<int>(totalSize), m_imageObserver.m_lastDecodedSizeChangedDelta);
+    EXPECT_EQ(-static_cast<int>(totalSize), m_imageObserver->m_lastDecodedSizeChangedDelta);
     EXPECT_EQ(0u, decodedSize());
 }
 
 TEST_F(BitmapImageTest, maybeAnimated)
 {
     loadImage("/LayoutTests/fast/images/resources/gif-loop-count.gif");
     for (size_t i = 0; i < frameCount(); ++i) {
         EXPECT_TRUE(m_image->maybeAnimated());
         advanceAnimation();
     }
@@ skipping 65 matching lines @@
 }
 
 TEST_F(BitmapImageTest, correctDecodedDataSize)
 {
     // When requesting a frame of a multi-frame GIF causes another frame to be
     // decoded as well, both frames' sizes should be reported by the source and
     // thus included in the decoded size changed notification.
     loadImage("/LayoutTests/fast/images/resources/anim_none.gif", false);
     frameAtIndex(1);
     int frameSize = static_cast<int>(m_image->size().area() * sizeof(ImageFrame::PixelData));
-    EXPECT_EQ(frameSize * 2, m_imageObserver.m_lastDecodedSizeChangedDelta);
+    EXPECT_EQ(frameSize * 2, m_imageObserver->m_lastDecodedSizeChangedDelta);
 
     // Trying to destroy all data except an undecoded frame should cause the
     // decoder to seek backwards and preserve the most recent previous frame
     // necessary to decode that undecoded frame, and destroy all other frames.
     setCurrentFrame(2);
     destroyDecodedData(false);
-    EXPECT_EQ(-frameSize, m_imageObserver.m_lastDecodedSizeChangedDelta);
+    EXPECT_EQ(-frameSize, m_imageObserver->m_lastDecodedSizeChangedDelta);
 }
 
 TEST_F(BitmapImageTest, recachingFrameAfterDataChanged)
 {
     loadImage("/LayoutTests/fast/images/resources/green.jpg");
     setFirstFrameNotComplete();
-    EXPECT_GT(m_imageObserver.m_lastDecodedSizeChangedDelta, 0);
-    m_imageObserver.m_lastDecodedSizeChangedDelta = 0;
+    EXPECT_GT(m_imageObserver->m_lastDecodedSizeChangedDelta, 0);
+    m_imageObserver->m_lastDecodedSizeChangedDelta = 0;
 
     // Calling dataChanged causes the cache to flush, but doesn't affect the
     // source's decoded frames. It shouldn't affect decoded size.
     m_image->dataChanged(true);
-    EXPECT_EQ(0, m_imageObserver.m_lastDecodedSizeChangedDelta);
+    EXPECT_EQ(0, m_imageObserver->m_lastDecodedSizeChangedDelta);
     // Recaching the first frame also shouldn't affect decoded size.
     m_image->imageForCurrentFrame();
-    EXPECT_EQ(0, m_imageObserver.m_lastDecodedSizeChangedDelta);
+    EXPECT_EQ(0, m_imageObserver->m_lastDecodedSizeChangedDelta);
 }
 
 class BitmapImageDeferredDecodingTest : public BitmapImageTest {
 public:
     BitmapImageDeferredDecodingTest() : BitmapImageTest(true) { }
 };
 
 TEST_F(BitmapImageDeferredDecodingTest, correctDecodedDataSize)
 {
     // When deferred decoding is enabled, requesting any one frame shouldn't
     // result in decoding any other frames.
     loadImage("/LayoutTests/fast/images/resources/anim_none.gif", false);
     frameAtIndex(1);
     int frameSize = static_cast<int>(m_image->size().area() * sizeof(ImageFrame::PixelData));
-    EXPECT_EQ(frameSize, m_imageObserver.m_lastDecodedSizeChangedDelta);
+    EXPECT_EQ(frameSize, m_imageObserver->m_lastDecodedSizeChangedDelta);
     frameAtIndex(0);
 
     // Trying to destroy all data except an undecoded frame should go ahead and
     // destroy all other frames.
     setCurrentFrame(2);
     destroyDecodedData(false);
-    EXPECT_EQ(-frameSize * 2, m_imageObserver.m_lastDecodedSizeChangedDelta);
+    EXPECT_EQ(-frameSize * 2, m_imageObserver->m_lastDecodedSizeChangedDelta);
 }
 
 } // namespace blink