Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1610833004: Remove Windows XP SHA-256 and ECDSA logic. (Closed)

Created:
4 years, 11 months ago by davidben
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vmpstr+watch_chromium.org, grt+watch_chromium.org, jam, darin-cc_chromium.org, wfh+watch_chromium.org, Sorin Jianu, waffles
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Windows XP SHA-256 and ECDSA logic. We can assume the system verifier handles both SHA-256 and ECDSA now. No need to inject SHA-256 support or disable ECDSA ciphers. BUG=554410 Committed: https://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f Cr-Commit-Position: refs/heads/master@{#371329}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -557 lines) Patch
M base/win/win_util.h View 1 chunk +0 lines, -7 lines 0 comments Download
M base/win/win_util.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/extensions/updater/chrome_update_client_config.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/component_updater/component_updater_url_constants.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/component_updater/component_updater_url_constants.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/component_updater/configurator_impl.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M components/component_updater/configurator_impl.cc View 1 5 chunks +1 line, -24 lines 0 comments Download
M content/browser/browser_main_runner.cc View 3 chunks +0 lines, -85 lines 2 comments Download
D net/cert/sha256_legacy_support_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D net/cert/sha256_legacy_support_win.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D net/cert/sha256_legacy_support_win_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M net/data/ssl/certificates/README View 1 chunk +0 lines, -2 lines 0 comments Download
D net/data/ssl/certificates/sha256.pem View 1 chunk +0 lines, -70 lines 0 comments Download
M net/data/ssl/scripts/generate-test-certs.sh View 1 chunk +0 lines, -6 lines 0 comments Download
M net/net.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
Ryan Sleevi
\(^o^)/ LGTM https://codereview.chromium.org/1610833004/diff/40001/content/browser/browser_main_runner.cc File content/browser/browser_main_runner.cc (right): https://codereview.chromium.org/1610833004/diff/40001/content/browser/browser_main_runner.cc#newcode88 content/browser/browser_main_runner.cc:88: if (base::win::GetVersion() < base::win::VERSION_VISTA) { Oooh, we ...
4 years, 11 months ago (2016-01-21 22:43:06 UTC) #3
Will Harris
On 2016/01/21 22:43:06, Ryan Sleevi wrote: > \(^o^)/ > > LGTM > > https://codereview.chromium.org/1610833004/diff/40001/content/browser/browser_main_runner.cc > ...
4 years, 11 months ago (2016-01-21 22:43:55 UTC) #4
davidben
+cpu for base/win and components/component_updater +asargent for chrome/browser/extensions/updater https://codereview.chromium.org/1610833004/diff/40001/content/browser/browser_main_runner.cc File content/browser/browser_main_runner.cc (right): https://codereview.chromium.org/1610833004/diff/40001/content/browser/browser_main_runner.cc#newcode88 content/browser/browser_main_runner.cc:88: if ...
4 years, 11 months ago (2016-01-21 22:50:46 UTC) #7
asargent_no_longer_on_chrome
hooray, lgtm +cc sorin as FYI
4 years, 11 months ago (2016-01-21 23:06:40 UTC) #8
cpu_(ooo_6.6-7.5)
+Sorin anyhow.
4 years, 11 months ago (2016-01-22 17:17:08 UTC) #10
cpu_(ooo_6.6-7.5)
base/win lgtm
4 years, 11 months ago (2016-01-22 17:17:40 UTC) #11
Sorin Jianu
lgtm thank you!
4 years, 11 months ago (2016-01-25 19:15:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610833004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610833004/40001
4 years, 11 months ago (2016-01-25 19:19:27 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-25 22:08:06 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:12:17 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c0aa77c46d827484a01662cc0eb383e7de6d93f
Cr-Commit-Position: refs/heads/master@{#371329}

Powered by Google App Engine
This is Rietveld 408576698