Make NodeList::ownerNode() virtual and rename to virtualOwnerNode()

Make NodeList::ownerNode() virtual and rename to virtualOwnerNode()

Make NodeList::ownerNode() virtual to avoid multiple virtual calls to
is*NodeList() in Node::ownerNode() as well as casting.

NodeList::ownerNode() is also renamed to virtualOwnerNode() to avoid
conflict with LiveNodeListBase::ownerNode(). Also, we don't want
LiveNodeList::ownerNode() to be virtual as it is called from hot
code paths.

R=haraken, adamk

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167061

[adamk, 2014-02-12 21:34:27]

Can you re-upload? I'm not seeing anything in the diffs.

[Inactive, 2014-02-12 21:39:42]

On 2014/02/12 21:34:27, adamk wrote:
> Can you re-upload? I'm not seeing anything in the diffs.

Done, sorry about that.

[adamk, 2014-02-12 22:02:14]

lgtm

https://codereview.chromium.org/161083002/diff/2/Source/bindings/IDLExtendedA...
File Source/bindings/IDLExtendedAttributes.txt (right):

https://codereview.chromium.org/161083002/diff/2/Source/bindings/IDLExtendedA...
Source/bindings/IDLExtendedAttributes.txt:87:
SetWrapperReferenceFrom=document|element|owner|ownerNode|virtualOwnerNode
I leave it up to haraken, but it's not clear to me why it's worth enumerating
these rather than just listing *

[haraken, 2014-02-12 23:12:45]

LGTM.

>
https://codereview.chromium.org/161083002/diff/2/Source/bindings/IDLExtendedA...
> Source/bindings/IDLExtendedAttributes.txt:87:
> SetWrapperReferenceFrom=document|element|owner|ownerNode|virtualOwnerNode
> I leave it up to haraken, but it's not clear to me why it's worth enumerating
> these rather than just listing *

nbarth@ prefers listing up the methods. Either is fine with me.

[Inactive, 2014-02-13 00:03:04]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-13 00:03:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/161083002/2

[Nils Barth (inactive), 2014-02-13 02:35:39]

>
https://codereview.chromium.org/161083002/diff/2/Source/bindings/IDLExtendedA...
> > Source/bindings/IDLExtendedAttributes.txt:87:
> > SetWrapperReferenceFrom=document|element|owner|ownerNode|virtualOwnerNode
> > I leave it up to haraken, but it's not clear to me why it's worth
enumerating
> > these rather than just listing *

On 2014/02/12 23:12:45, haraken wrote:
> nbarth@ prefers listing up the methods. Either is fine with me.

I made it an explicit list b/c it's a short list (4 items, now 5) and suggests a
naming convention;
if we're going to use lots of functions, it's fine to list *;
I don't know how widely used this is or is expected to be.

[commit-bot: I haz the power, 2014-02-13 03:24:44]

Change committed as 167061

[Nils Barth (inactive), 2014-02-26 07:25:02]

On 2014/02/13 02:35:39, Nils Barth wrote:
> >
>
https://codereview.chromium.org/161083002/diff/2/Source/bindings/IDLExtendedA...
> > > Source/bindings/IDLExtendedAttributes.txt:87:
> > > SetWrapperReferenceFrom=document|element|owner|ownerNode|virtualOwnerNode
> > > I leave it up to haraken, but it's not clear to me why it's worth
> enumerating
> > > these rather than just listing *
> 
> On 2014/02/12 23:12:45, haraken wrote:
> > nbarth@ prefers listing up the methods. Either is fine with me.
> 
> I made it an explicit list b/c it's a short list (4 items, now 5) and suggests
a
> naming convention;
> if we're going to use lots of functions, it's fine to list *;
> I don't know how widely used this is or is expected to be.

Seems better to use *, as more functions are being added; fixed in:
Allow arbitrary values for [SetWrapperReferenceFrom]
https://codereview.chromium.org/181133002/