Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

chrome/browser/chromeos/login/ui/webui_login_display.cc

Index: chrome/browser/chromeos/login/ui/webui_login_display.cc
diff --git a/chrome/browser/chromeos/login/ui/webui_login_display.cc b/chrome/browser/chromeos/login/ui/webui_login_display.cc
index 782ad0fcfaacb3b302044f343e1304020fe8f728..e322ebeff217fe0687d69fb3a48a3aa333f2cdea 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_display.cc
+++ b/chrome/browser/chromeos/login/ui/webui_login_display.cc
@@ -9,7 +9,7 @@
 #include "chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h"
 #include "chrome/browser/chromeos/login/signin_screen_controller.h"
 #include "chrome/browser/chromeos/login/startup_utils.h"
-#include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
+#include "chrome/browser/chromeos/login/ui/login_display_host.h"
 #include "chrome/browser/chromeos/login/ui/user_adding_screen.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
@@ -98,7 +98,7 @@ void WebUILoginDisplay::SetUIEnabled(bool is_enabled) {
   }
 
   if (chromeos::LoginDisplayHost* host =
-          chromeos::LoginDisplayHostImpl::default_host()) {
+          chromeos::LoginDisplayHost::default_host()) {

[achuithb, 2016/01/21 23:14:31]

drop chromeos::

Pull the assignment out of the if stmt please while you're here

[dzhioev (left Google), 2016/01/21 23:25:04]

Hmm, what's wrong with the assignment?

[achuithb, 2016/01/21 23:33:53]

Is this normal? The pattern I'm familiar with is:
LoginDisplayHost* host = LoginDisplayHost::default_host();
if (host) {
...

Is it stylistically ok to have an assignment as a condition in an if stmt? I'm
not able to find anything in the style guide that forbids this, so maybe it's
ok, but this is the first time I'm seeing this in the chromium code base.

[jdufault, 2016/01/22 21:14:11]

I've reworked this to avoid the nested if. It also removes the assignment inside
the if.

[achuithb, 2016/01/22 22:37:08]

Thank you! This is more concise and familiar.

     if (chromeos::WebUILoginView* login_view = host->GetWebUILoginView())
       login_view->SetUIEnabled(is_enabled);
   }