[Media Router] Make header text clickable to switch between sink list and cast mode views.

[Media Router] Make header text clickable to switch between sink list and cast mode views.

This change makes the header text fire the same event as the drop arrow icon when the current view is the cast mode or sink list view. The cursor styling for the header text is also updated to match the drop arrow icon when clickable.

Also added restrictions to deter from potentially ending up in weird states if assumptions are made and added more tests to cover the different views.

BUG=579131
Committed: https://crrev.com/8031e4ce55731df9dd7c5e680877454a670dbc5a
Cr-Commit-Position: refs/heads/master@{#371379}

[apacible, 2016-01-20 06:59:05]

Description was changed from

==========
header arrow click

BUG=
==========

to

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

BUG=579131
==========

[apacible, 2016-01-20 22:27:01]

Patchset #1 (id:1) has been deleted

[apacible, 2016-01-20 22:39:53]

Description was changed from

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

BUG=579131
==========

to

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

This change makes the header text fire the same event as the drop arrow icon
when the current view is the cast mode or sink list view. The cursor styling for
the header text is also updated to match the drop arrow icon when clickable.


Also added restrictions to deter from potentially ending up in weird states if
assumptions are made and added more tests to cover the different views.

BUG=579131
==========

[apacible, 2016-01-20 22:39:53]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-01-20 22:40:17]

Description was changed from

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

This change makes the header text fire the same event as the drop arrow icon
when the current view is the cast mode or sink list view. The cursor styling for
the header text is also updated to match the drop arrow icon when clickable.


Also added restrictions to deter from potentially ending up in weird states if
assumptions are made and added more tests to cover the different views.

BUG=579131
==========

to

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

This change makes the header text fire the same event as the drop arrow icon
when the current view is the cast mode or sink list view. The cursor styling for
the header text is also updated to match the drop arrow icon when clickable.

Also added restrictions to deter from potentially ending up in weird states if
assumptions are made and added more tests to cover the different views.

BUG=579131
==========

[apacible, 2016-01-20 22:41:03]

PTAL, thanks!

No cosmetic changes except for the cursor style, which I can't get a screenshot
of. Let me know if you want to see it in person.

[imcheng, 2016-01-25 20:42:17]

lgtm

https://codereview.chromium.org/1610523002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
(right):

https://codereview.chromium.org/1610523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js:130:
updateCursorStyle_: function(view) {
nit: updateHeaderCursorStyle_

[apacible, 2016-01-25 22:52:09]

https://codereview.chromium.org/1610523002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
(right):

https://codereview.chromium.org/1610523002/diff/20001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js:130:
updateCursorStyle_: function(view) {
On 2016/01/25 20:42:17, imcheng1 wrote:
> nit: updateHeaderCursorStyle_

Done.

[apacible, 2016-01-25 23:02:11]

The CQ bit was checked by apacible@chromium.org

[apacible, 2016-01-25 23:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1610523002/#ps40001
(title: "Changes per imcheng@'s comments.")

[commit-bot: I haz the power, 2016-01-25 23:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610523002/40001

[commit-bot: I haz the power, 2016-01-26 00:30:59]

Description was changed from

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

This change makes the header text fire the same event as the drop arrow icon
when the current view is the cast mode or sink list view. The cursor styling for
the header text is also updated to match the drop arrow icon when clickable.

Also added restrictions to deter from potentially ending up in weird states if
assumptions are made and added more tests to cover the different views.

BUG=579131
==========

to

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

This change makes the header text fire the same event as the drop arrow icon
when the current view is the cast mode or sink list view. The cursor styling for
the header text is also updated to match the drop arrow icon when clickable.

Also added restrictions to deter from potentially ending up in weird states if
assumptions are made and added more tests to cover the different views.

BUG=579131
==========

[commit-bot: I haz the power, 2016-01-26 00:30:59]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-01-26 00:32:00]

Description was changed from

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

This change makes the header text fire the same event as the drop arrow icon
when the current view is the cast mode or sink list view. The cursor styling for
the header text is also updated to match the drop arrow icon when clickable.

Also added restrictions to deter from potentially ending up in weird states if
assumptions are made and added more tests to cover the different views.

BUG=579131
==========

to

==========
[Media Router] Make header text clickable to switch between sink list and cast
mode views.

This change makes the header text fire the same event as the drop arrow icon
when the current view is the cast mode or sink list view. The cursor styling for
the header text is also updated to match the drop arrow icon when clickable.

Also added restrictions to deter from potentially ending up in weird states if
assumptions are made and added more tests to cover the different views.

BUG=579131

Committed: https://crrev.com/8031e4ce55731df9dd7c5e680877454a670dbc5a
Cr-Commit-Position: refs/heads/master@{#371379}
==========

[commit-bot: I haz the power, 2016-01-26 00:32:01]

Patchset 2 (id:??) landed as
https://crrev.com/8031e4ce55731df9dd7c5e680877454a670dbc5a
Cr-Commit-Position: refs/heads/master@{#371379}