Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5150)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js

Issue 1610523002: [Media Router] Make header text clickable to switch between sink list and cast mode views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per imcheng@'s comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
index 3e9ea19c5e6d8a58fd6d3d5be0409a15627b6361..3afac7f4c94f5f801b7cd3894fa72c585f64f2aa 100644
--- a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
+++ b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
@@ -42,6 +42,7 @@ Polymer({
view: {
type: String,
value: null,
+ observer: 'updateHeaderCursorStyle_',
},
/**
@@ -94,8 +95,11 @@ Polymer({
*
* @private
*/
- onArrowDropClick_: function() {
- this.fire('arrow-drop-click');
+ onHeaderOrArrowClick_: function() {
+ if (this.view == media_router.MediaRouterView.SINK_LIST ||
+ this.view == media_router.MediaRouterView.CAST_MODE_LIST) {
+ this.fire('header-or-arrow-click');
+ }
},
/**
@@ -115,4 +119,18 @@ Polymer({
onCloseButtonClick_: function() {
this.fire('close-button-click');
},
+
+ /**
+ * Updates the cursor style for the header text when the view changes. When
+ * the drop arrow is also shown, the header text is also clickable.
+ *
+ * @param {?media_router.MediaRouterView} view The current view.
+ * @private
+ */
+ updateHeaderCursorStyle_: function(view) {
+ this.$$('#header-text').style.cursor =
+ view == media_router.MediaRouterView.SINK_LIST ||
+ view == media_router.MediaRouterView.CAST_MODE_LIST ?
+ 'pointer' : 'auto';
+ },
});

Powered by Google App Engine
This is Rietveld 408576698