third_party/WebKit/public/platform/WebMediaRecorderHandler.h - Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebMediaRecorderHandler.h

Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed. Added TODO for unsigned->signed change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/public/platform/WebMediaRecorderHandler.h

diff --git a/third_party/WebKit/public/platform/WebMediaRecorderHandler.h b/third_party/WebKit/public/platform/WebMediaRecorderHandler.h

index 2bb32a9b7d6b002a73e8588a275d42c1b75d192d..15089de8ba817932acb6b91166bbfc9d8e8ef79c 100644

--- a/third_party/WebKit/public/platform/WebMediaRecorderHandler.h

+++ b/third_party/WebKit/public/platform/WebMediaRecorderHandler.h

@@ -17,7 +17,7 @@ class WebString;

class BLINK_PLATFORM_EXPORT WebMediaRecorderHandler {

public:

virtual ~WebMediaRecorderHandler() = default;

- virtual bool initialize(WebMediaRecorderHandlerClient* client, const WebMediaStream& stream, const WebString& type, const WebString& codecs) { return false; }

+ virtual bool initialize(WebMediaRecorderHandlerClient* client, const WebMediaStream& stream, const WebString& type, const WebString& codecs, int32_t audioBitsPerSecond, int32_t videoBitsPerSecond) { return false; }

virtual bool start() { return false; }

virtual bool start(int timeslice) { return false; }

virtual void stop() {}

« content/renderer/media/audio_track_recorder.cc ('K') | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl ('k') | no next file » | no next file with comments »