third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl - Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed. Added TODO for unsigned->signed change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_track_recorder.cc ('K') | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('k') | third_party/WebKit/public/platform/WebMediaRecorderHandler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

index c816d41276d9fd7585b208ee32c0a5a023d9c43a..1abbb45bfc1eedd43fbc890129c786e969bbe037 100644

--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

@@ -7,5 +7,8 @@

dictionary MediaRecorderOptions {

DOMString mimeType; // Encoding mimeType.

- // TODO(mcasas): Include here the remaining spec |{audioBits,videoBits,bits}PerSecond| when adding support for them.

+ // TODO(mcasas): Consider changing the following options to signed: https://github.com/w3c/mediacapture-record/issues/48, and/or using [EnforceRange]/[Clamp].

+ unsigned long audioBitsPerSecond = 0;

+ unsigned long videoBitsPerSecond = 0;

+ unsigned long bitsPerSecond = 0;

};