Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1610233002: [Reland] Remove PaintInfo's paintingRoot (Closed)

Created:
4 years, 11 months ago by pdr.
Modified:
4 years, 11 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Remove PaintInfo's paintingRoot PaintInfo had a paintingRoot member for supporting drawing a single layout object (including descendants). This complexity is spread throughout the painting code and only exists to support drag and drop drag images: https://chromium.googlesource.com/chromium/src/+/65e7e9d4860e50bb677228f0b83848cce208eb76 This patch switches to directly painting LayoutObjects and removes the complex paintingRoot code. ClusterTelemetry results: 0.5% record time savings: https://storage.cloud.google.com/cluster-telemetry/tasks/chromium_perf_runs/pdr-20160118203222/html/index.html (Original attempt at https://codereview.chromium.org/1602513004) BUG=577004 TBR=chrishtr Committed: https://crrev.com/8b1bccd2aa7837bcd52b217c6b32f2a507240374 Cr-Commit-Position: refs/heads/master@{#370476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -209 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 5 chunks +70 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.h View 4 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.h View 2 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 11 chunks +38 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 3 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610233002/1
4 years, 11 months ago (2016-01-20 19:11:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 20:24:08 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 20:26:26 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8b1bccd2aa7837bcd52b217c6b32f2a507240374
Cr-Commit-Position: refs/heads/master@{#370476}

Powered by Google App Engine
This is Rietveld 408576698