third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp - Issue 1610233002: [Reland] Remove PaintInfo's paintingRoot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp

Issue 1610233002: [Reland] Remove PaintInfo's paintingRoot (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ReplacedPainter.cpp ('k') | third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp b/third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp

index 996b6231678a9d5230caa5a20822c8d29f358144..4e9510bc7c5fb4e9f9bc7b48ef8010fae88e5dbb 100644

--- a/third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp

@@ -13,8 +13,7 @@ namespace blink {

void RootInlineBoxPainter::paintEllipsisBox(const PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit lineTop, LayoutUnit lineBottom) const

{

- if (m_rootInlineBox.hasEllipsisBox() && paintInfo.shouldPaintWithinRoot(LineLayoutPaintShim::layoutObjectFrom(m_rootInlineBox.lineLayoutItem())) && m_rootInlineBox.lineLayoutItem().style()->visibility() == VISIBLE

- && paintInfo.phase == PaintPhaseForeground)

+ if (m_rootInlineBox.hasEllipsisBox() && m_rootInlineBox.lineLayoutItem().style()->visibility() == VISIBLE && paintInfo.phase == PaintPhaseForeground)

m_rootInlineBox.ellipsisBox()->paint(paintInfo, paintOffset, lineTop, lineBottom);

}