Add template parameter to ReturnValue::Set.

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 7dfc9189aa307198416f02c8f804c10d1653adbe..0cdb132a65a4d1eb38fab9f5d239e10859383e6f 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2779,8 +2779,8 @@ class ReturnValue {
  public:
   V8_INLINE(explicit ReturnValue(internal::Object** slot));
   // Handle setters
-  V8_INLINE(void Set(const Persistent<T>& handle));
-  V8_INLINE(void Set(const Handle<T> handle));
+  template <typename S> V8_INLINE(void Set(const Persistent<S>& handle));
+  template <typename S> V8_INLINE(void Set(const Handle<S> handle));
   // Fast primitive setters
   V8_INLINE(void Set(Isolate* isolate, bool value));
   V8_INLINE(void Set(Isolate* isolate, double i));
@@ -5684,12 +5684,14 @@ template<typename T>
 ReturnValue<T>::ReturnValue(internal::Object** slot) : value_(slot) {}
 
 template<typename T>
-void ReturnValue<T>::Set(const Persistent<T>& handle) {
+template<typename S>
+void ReturnValue<T>::Set(const Persistent<S>& handle) {

[dcarney, 2013/05/27 12:34:36]

you need the correct type check here
and a test to make sure the type_cast is called correctly

[marja, 2013/05/27 13:09:28]

Done.

   *value_ = *reinterpret_cast<internal::Object**>(*handle);
 }
 
 template<typename T>
-void ReturnValue<T>::Set(const Handle<T> handle) {
+template<typename S>
+void ReturnValue<T>::Set(const Handle<S> handle) {
   *value_ = *reinterpret_cast<internal::Object**>(*handle);
 }