Add template parameter to ReturnValue::Set.

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2761 matching lines @@
   friend class ObjectTemplate;
   friend class FunctionTemplate;
 };
 
 
 template<typename T>
 class ReturnValue {
  public:
   V8_INLINE(explicit ReturnValue(internal::Object** slot));
   // Handle setters
-  V8_INLINE(void Set(const Persistent<T>& handle));
-  V8_INLINE(void Set(const Handle<T> handle));
+  template <typename S> V8_INLINE(void Set(const Persistent<S>& handle));
+  template <typename S> V8_INLINE(void Set(const Handle<S> handle));
   // Fast primitive setters
   V8_INLINE(void Set(Isolate* isolate, bool value));
   V8_INLINE(void Set(Isolate* isolate, double i));
   V8_INLINE(void Set(Isolate* isolate, int32_t i));
   V8_INLINE(void Set(Isolate* isolate, uint32_t i));
   // Fast JS primitive setters
   V8_INLINE(void SetNull(Isolate* isolate));
   V8_INLINE(void SetUndefined(Isolate* isolate));
  private:
   V8_INLINE(void SetTrue(Isolate* isolate));
@@ skipping 2883 matching lines @@
   internal::Object** obj = reinterpret_cast<internal::Object**>(this->val_);
   uint8_t* addr = reinterpret_cast<uint8_t*>(obj) + I::kNodeClassIdOffset;
   return *reinterpret_cast<uint16_t*>(addr);
 }
 
 
 template<typename T>
 ReturnValue<T>::ReturnValue(internal::Object** slot) : value_(slot) {}
 
 template<typename T>
-void ReturnValue<T>::Set(const Persistent<T>& handle) {
+template<typename S>
+void ReturnValue<T>::Set(const Persistent<S>& handle) {

[dcarney, 2013/05/27 12:34:36]

you need the correct type check here
and a test to make sure the type_cast is called correctly

[marja, 2013/05/27 13:09:28]

Done.

   *value_ = *reinterpret_cast<internal::Object**>(*handle);
 }
 
 template<typename T>
-void ReturnValue<T>::Set(const Handle<T> handle) {
+template<typename S>
+void ReturnValue<T>::Set(const Handle<S> handle) {
   *value_ = *reinterpret_cast<internal::Object**>(*handle);
 }
 
 template<typename T>
 void ReturnValue<T>::Set(Isolate* isolate, double i) {
   Set(Number::New(isolate, i));
 }
 
 template<typename T>
 void ReturnValue<T>::Set(Isolate* isolate, int32_t i) {
@@ skipping 621 matching lines @@
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_