Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 16102002: Add template parameter to ReturnValue::Set. (Closed)

Created:
7 years, 7 months ago by marja
Modified:
7 years, 7 months ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Add template parameter to ReturnValue::Set. E.g., v8-i18n wants to set the return value with a different type of a Persistent. BUG=NONE R=dcarney@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14826

Patch Set 1 #

Total comments: 2

Patch Set 2 : type check and tests #

Patch Set 3 : simpler test #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M include/v8.h View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcarney
https://codereview.chromium.org/16102002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/16102002/diff/1/include/v8.h#newcode5688 include/v8.h:5688: void ReturnValue<T>::Set(const Persistent<S>& handle) { you need the correct ...
7 years, 7 months ago (2013-05-27 12:34:36 UTC) #1
marja
https://codereview.chromium.org/16102002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/16102002/diff/1/include/v8.h#newcode5688 include/v8.h:5688: void ReturnValue<T>::Set(const Persistent<S>& handle) { On 2013/05/27 12:34:36, dcarney ...
7 years, 7 months ago (2013-05-27 13:09:28 UTC) #2
dcarney
lgtm
7 years, 7 months ago (2013-05-27 13:13:46 UTC) #3
marja
(as discussed, simplified the test) svenpanne, could you review this?
7 years, 7 months ago (2013-05-27 13:30:43 UTC) #4
Sven Panne
lgtm
7 years, 7 months ago (2013-05-27 13:56:01 UTC) #5
dcarney
7 years, 7 months ago (2013-05-27 14:34:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r14826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698