Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1610163003: Merge to XFA: Replace more CFX_MapPtrToPtr. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Replace more CFX_MapPtrToPtr. Original Review URL: https://codereview.chromium.org/1580573002 . (cherry picked from commit a505d9d3e13485e090e50d5d83f882fb707d3f48) R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fcb6398ea511e32a09d192543f70041b82646df1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -59 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_basic.h View 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 5 chunks +9 lines, -23 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 3 chunks +16 lines, -14 lines 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 3 chunks +5 lines, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 3 chunks +9 lines, -14 lines 0 comments Download
M pdfium.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
ochang, manual changes in core/include/fxcrt/fx_basic.h, BUILD.gn, pdfium.gyp.
4 years, 11 months ago (2016-01-20 22:21:19 UTC) #1
Oliver Chang
lgtm
4 years, 11 months ago (2016-01-20 22:28:29 UTC) #2
Tom Sepez
4 years, 11 months ago (2016-01-20 22:33:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcb6398ea511e32a09d192543f70041b82646df1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698