Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1580573002: Replace more CFX_MapPtrToPtr and remove it. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace more CFX_MapPtrToPtr and remove it. Still used by XFA, so the merge will make this XFA only. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a505d9d3e13485e090e50d5d83f882fb707d3f48

Patch Set 1 #

Patch Set 2 : iwyu #

Patch Set 3 : Rebase #

Patch Set 4 : And remove it. #

Total comments: 4

Patch Set 5 : Remove pFont #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -281 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 2 3 1 chunk +0 lines, -64 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 5 chunks +9 lines, -23 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 3 chunks +16 lines, -14 lines 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 2 chunks +6 lines, -3 lines 0 comments Download
D core/src/fxcrt/fx_basic_maps.cpp View 1 2 3 1 chunk +0 lines, -159 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 1 2 3 4 3 chunks +9 lines, -14 lines 0 comments Download
M pdfium.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
Oliver, please review.
4 years, 11 months ago (2016-01-20 21:03:53 UTC) #2
Tom Sepez
Note that we don't have a bot for the /android file, so pls double-check it.
4 years, 11 months ago (2016-01-20 21:19:32 UTC) #5
Oliver Chang
lgtm https://codereview.chromium.org/1580573002/diff/60001/core/include/fpdfapi/fpdf_parser.h File core/include/fpdfapi/fpdf_parser.h (right): https://codereview.chromium.org/1580573002/diff/60001/core/include/fpdfapi/fpdf_parser.h#newcode548 core/include/fpdfapi/fpdf_parser.h:548: std::map<FX_DWORD, std::unique_ptr<CPDF_StreamAcc>> m_ObjectStreamMap; awesome, we can do this ...
4 years, 11 months ago (2016-01-20 21:34:24 UTC) #6
Tom Sepez
Committed patchset #5 (id:80001) manually as a505d9d3e13485e090e50d5d83f882fb707d3f48 (presubmit successful).
4 years, 11 months ago (2016-01-20 22:06:29 UTC) #8
Tom Sepez
4 years, 11 months ago (2016-01-20 22:18:30 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1580573002/diff/60001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_parser.h (right):

https://codereview.chromium.org/1580573002/diff/60001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_parser.h:548: std::map<FX_DWORD,
std::unique_ptr<CPDF_StreamAcc>> m_ObjectStreamMap;
On 2016/01/20 21:34:24, Oliver Chang wrote:
Yes, ScopedVector is retired.

https://codereview.chromium.org/1580573002/diff/60001/core/src/fxge/android/f...
File core/src/fxge/android/fpf_skiafontmgr.cpp (right):

https://codereview.chromium.org/1580573002/diff/60001/core/src/fxge/android/f...
core/src/fxge/android/fpf_skiafontmgr.cpp:263: IFPF_Font* pFont = NULL;
On 2016/01/20 21:34:24, Oliver Chang wrote:
> nit: I don't think this |pFont| variable is needed at all.

Done.

Powered by Google App Engine
This is Rietveld 408576698