Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1610153002: Allocator cleanup: move tcmalloc-specific calls to base (Closed)

Created:
4 years, 11 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_nonbase_tcmalloc_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allocator cleanup: move tcmalloc-specific calls to base After crrev.com/1584893002 base/ can use directly allocator. The grand plan is to dismantle all the indirection layer such that: - base is the only thing that knows about allocator-specific details. - non-base code uses only base abstractions and stops looking at USE_TCMALLOC build flags. This CL specifically deals with tc_malloc_skip_handler and tc_set_new_mode and removes the unnecessary base -> content -> base hops. BUG=564618 Committed: https://crrev.com/f7b03f4b26ee936818a896f244d56db8e18a7c49 Cr-Commit-Position: refs/heads/master@{#371355}

Patch Set 1 #

Patch Set 2 : README.chromium #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -40 lines) Patch
M base/process/memory_linux.cc View 3 chunks +6 lines, -14 lines 0 comments Download
M content/app/content_main_runner.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M third_party/tcmalloc/README.chromium View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h View 1 chunk +1 line, -0 lines 2 comments Download
M third_party/tcmalloc/chromium/src/tcmalloc.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (7 generated)
Primiano Tucci (use gerrit)
Will, let's the cleanup being! Having done the base->allocator step, these cleanup CLs should be ...
4 years, 11 months ago (2016-01-20 16:51:02 UTC) #2
Will Harris
https://codereview.chromium.org/1610153002/diff/60001/third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h File third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h (right): https://codereview.chromium.org/1610153002/diff/60001/third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h#newcode96 third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h:96: PERFTOOLS_DLL_DECL void* tc_malloc_skip_new_handler(size_t size); now this is a first ...
4 years, 11 months ago (2016-01-21 17:56:35 UTC) #3
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1610153002/diff/60001/third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h File third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h (right): https://codereview.chromium.org/1610153002/diff/60001/third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h#newcode96 third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h:96: PERFTOOLS_DLL_DECL void* tc_malloc_skip_new_handler(size_t size); On 2016/01/21 17:56:34, Will Harris ...
4 years, 11 months ago (2016-01-21 18:01:09 UTC) #4
Will Harris
On 2016/01/21 18:01:09, Primiano Tucci wrote: > https://codereview.chromium.org/1610153002/diff/60001/third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h > File third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h (right): > > https://codereview.chromium.org/1610153002/diff/60001/third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h#newcode96 ...
4 years, 11 months ago (2016-01-25 18:12:34 UTC) #5
Primiano Tucci (use gerrit)
On 2016/01/25 18:12:34, Will Harris wrote: > no I'm saying it should be declared by ...
4 years, 11 months ago (2016-01-25 18:17:18 UTC) #6
Will Harris
On 2016/01/25 18:17:18, Primiano Tucci wrote: > On 2016/01/25 18:12:34, Will Harris wrote: > > ...
4 years, 11 months ago (2016-01-25 18:32:57 UTC) #7
Primiano Tucci (use gerrit)
+sievers for -19 lines in content_main_runner.cc +thakis for 20 lines in base/process/memory_linux.cc
4 years, 11 months ago (2016-01-25 18:39:27 UTC) #9
no sievers
lgtm
4 years, 11 months ago (2016-01-25 19:17:39 UTC) #10
Primiano Tucci (use gerrit)
+thestig for base/
4 years, 11 months ago (2016-01-25 19:25:08 UTC) #12
Nico
base/ lgtm
4 years, 11 months ago (2016-01-25 20:35:30 UTC) #13
commit-bot: I haz the power
This CL has an open dependency (Issue 1607303002 Patch 60001). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-25 21:44:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610153002/60001
4 years, 11 months ago (2016-01-25 22:38:32 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-26 00:00:34 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:02:26 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f7b03f4b26ee936818a896f244d56db8e18a7c49
Cr-Commit-Position: refs/heads/master@{#371355}

Powered by Google App Engine
This is Rietveld 408576698