Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1607303002: Allocator cleanup: allocator_extension call directly into tcmalloc (Closed)

Created:
4 years, 11 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org, jam, rickyz+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, Simon Que, bccheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@base_dep_alloc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allocator cleanup: allocator_extension call directly into tcmalloc After crrev.com/1584893002 base/ can use directly allocator. The grand plan is to dismantle all the indirection layer such that: - base is the only thing that knows about allocator-specific details. - non-base code uses only base abstractions and stops looking at USE_TCMALLOC build flags. This CL, specifically, addresses the profiling-related methods moving the tcmalloc-specific dependencies to base and base only. Other parts of the codebase will be cleaned up in separate CLs. Also this CL removes a stale base/debug/OWNERS. That file makes no sense these days as tracing has been moved to base/trace_event/. BUG=564618 Committed: https://crrev.com/d3a81abc8db50ba646915e3ef700c9ac45958c01 Cr-Commit-Position: refs/heads/master@{#371335}

Patch Set 1 #

Total comments: 1

Patch Set 2 : drop thunks injection #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -67 lines) Patch
M base/allocator/allocator_extension.h View 2 chunks +1 line, -17 lines 0 comments Download
M base/allocator/allocator_extension.cc View 1 chunk +17 lines, -19 lines 0 comments Download
D base/debug/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M base/debug/profiler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/debug/profiler.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (9 generated)
Primiano Tucci (use gerrit)
It's cleanup time +thakis for base/ +pkasting for chrome/browser/ui +jln@ for one-line change in content/browser/zygote_host ...
4 years, 11 months ago (2016-01-20 16:18:19 UTC) #3
Primiano Tucci (use gerrit)
+sque/bccheng FYI: this should not have any side effect on CrOs, at least not intentionally ...
4 years, 11 months ago (2016-01-20 16:22:28 UTC) #4
Peter Kasting
LGTM
4 years, 11 months ago (2016-01-20 20:48:41 UTC) #5
Primiano Tucci (use gerrit)
+sievers for -14 lines in content_main_runner.cc +mdempsky for 10 lines in zygote_host_impl_linux.cc PING thakis@ for ...
4 years, 11 months ago (2016-01-25 18:10:35 UTC) #7
mdempsky
On 2016/01/25 18:10:35, Primiano Tucci wrote: > +mdempsky for 10 lines in zygote_host_impl_linux.cc LGTM
4 years, 11 months ago (2016-01-25 18:23:00 UTC) #8
no sievers
lgtm
4 years, 11 months ago (2016-01-25 19:18:42 UTC) #9
Primiano Tucci (use gerrit)
+thestig for base/
4 years, 11 months ago (2016-01-25 19:33:01 UTC) #11
Will Harris
On 2016/01/25 19:33:01, Primiano Tucci wrote: > +thestig for base/ base/allocator lgtm
4 years, 11 months ago (2016-01-25 19:49:37 UTC) #12
Nico
lgtm, but please mention the base/debug/OWNERS deletion in the cl description ("while here, remove OWNERS ...
4 years, 11 months ago (2016-01-25 20:37:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607303002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607303002/80001
4 years, 11 months ago (2016-01-25 21:43:58 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-25 22:21:36 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:22:56 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d3a81abc8db50ba646915e3ef700c9ac45958c01
Cr-Commit-Position: refs/heads/master@{#371335}

Powered by Google App Engine
This is Rietveld 408576698