Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1610023003: Revert of Allow std::unordered_*. (Closed)

Created:
4 years, 11 months ago by davidben
Modified:
4 years, 11 months ago
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org, jbroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow std::unordered_*. (patchset #15 id:280001 of https://codereview.chromium.org/1502373009/ ) Reason for revert: MSan build failure. https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/12498 Original issue's description: > Allow std::unordered_*. > > base::hash_* is, as a transition step, implemented in terms of > std::unordered_*. Later commits will convert existing uses. > > Also fix a host of IWYU problems that arose from this CL. > > (NOPRESUBMIT because the wstring presubmit check is overzealous > and complains about the reference to wstring in the comment.) > > NOPRESUBMIT=true > BUG=576864 > TBR=derat@chromium.org,blundell@chromium.org,jbauman@chromium.org,dalecurtis@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/3f37f7f1459e7b5a452c0e433493e0a6e9649ca7 > Cr-Commit-Position: refs/heads/master@{#370553} TBR=danakj@chromium.org,thakis@chromium.org,derat@chromium.org,blundell@chromium.org,dalecurtis@chromium.org,jbauman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=576864 Committed: https://crrev.com/021a2b496a7eb7222c0c7f4d8cd01d697c3f2dda Cr-Commit-Position: refs/heads/master@{#370559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -255 lines) Patch
M ash/display/display_info.cc View 1 chunk +1 line, -4 lines 0 comments Download
M base/containers/hash_tables.h View 1 chunk +252 lines, -46 lines 0 comments Download
M base/containers/scoped_ptr_hash_map.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/hash.h View 2 chunks +0 lines, -81 lines 0 comments Download
M base/location.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/strings/string16.h View 2 chunks +0 lines, -17 lines 0 comments Download
M base/strings/string16_unittest.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M base/strings/string_piece.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/debug/picture_debug_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/quads/render_pass.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/quads/render_pass_id.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/quads/render_pass_id.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/surfaces/surface_sequence.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/tiles/image_decode_controller.h View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/devtools/devtools_file_watcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/log_private/filter_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google/google_brand.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_metrics.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/favicon_base/favicon_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/display_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_completeness_cache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/blink/multibuffer.h View 2 chunks +9 lines, -2 lines 0 comments Download
M net/base/network_change_notifier_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/port_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/server/web_socket_encoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/ssl/client_cert_store_nss.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M styleguide/c++/c++11.html View 4 chunks +43 lines, -43 lines 0 comments Download
M ui/base/x/selection_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/generic_shared_memory_id.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
davidben
Created Revert of Allow std::unordered_*.
4 years, 11 months ago (2016-01-21 01:35:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610023003/1
4 years, 11 months ago (2016-01-21 01:37:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 01:40:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/021a2b496a7eb7222c0c7f4d8cd01d697c3f2dda Cr-Commit-Position: refs/heads/master@{#370559}
4 years, 11 months ago (2016-01-21 01:41:44 UTC) #6
Nico
:-( The error probably needs something like https://chromium.googlesource.com/chromium/src/+/3ff31966063c8aa17d813c20592b198a59713333
4 years, 11 months ago (2016-01-21 01:43:47 UTC) #7
davidben
On 2016/01/21 01:43:47, Nico wrote: > :-( > > The error probably needs something like ...
4 years, 11 months ago (2016-01-21 01:48:13 UTC) #8
Nico
4 years, 11 months ago (2016-01-21 01:49:56 UTC) #9
Message was sent while issue was closed.
(see also https://code.google.com/p/chromium/issues/detail?id=562227)

On Wed, Jan 20, 2016 at 8:48 PM, <davidben@chromium.org> wrote:

> On 2016/01/21 01:43:47, Nico wrote:
>
>> :-(
>>
>
> The error probably needs something like
>>
>
>
>
https://chromium.googlesource.com/chromium/src/+/3ff31966063c8aa17d813c20592b...
>
> Ooh, thanks! That probably saved me a couple hours of head-bashing. I'll
> toy
> with it tomorrow.
>
> https://codereview.chromium.org/1610023003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698